Skip to content

fix: knowledge document create permission scope error #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peslyn merged 1 commit into from
Nov 12, 2026
Merged

fix: knowledge document create permission scope error #7860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common/auth/constants/permission_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ class PermissionConstants(Enum):
role_list=[RoleConstants.WORKSPACE_MANAGE, RoleConstants.USER],
category=Category.WORKSPACE,
resource_permission_group_list=[ResourcePermissionConst.KNOWLEDGE_MANAGE],
scope=[PermissionScopeConstants.WORKSPACE, PermissionScopeConstants.WORKSPACE],
scope=[PermissionScopeConstants.WORKSPACE, PermissionScopeConstants.WORKSPACE_RESOURCE],
),
)

@shaohuzhang1 shaohuzhang1 Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: the change itself looks like a likely bug fix, but it is security-sensitive and needs verification.

  • The original scope=[WORKSPACE, WORKSPACE] is suspicious: a duplicated scope is usually a copy/paste bug unless duplicates are intentionally allowed.
  • Changing the second value to WORKSPACE_RESOURCE is probably correct if scope is positionally aligned with role_list, i.e.:
    • WORKSPACE_MANAGE → WORKSPACE
    • USER → WORKSPACE_RESOURCE
  • If scope is not positional and is instead a set of accepted scopes, this change expands the accepted scope set and may unintentionally grant or change access. Confirm the authorization semantics.
  • Confirm PermissionScopeConstants.WORKSPACE_RESOURCE exists and is compatible with ResourcePermissionConst.KNOWLEDGE_MANAGE.
  • Check whether permission definitions are cached, persisted, or seeded. If so, invalidate/backfill caches or data after this change.
  • Add/update tests for both roles:
    • WORKSPACE_MANAGE still gets workspace-level access.
    • USER gets resource-level access and cannot perform workspace-level operations.
  • A robustness improvement is to avoid positional lists for role/scope mapping, or at least validate length/alignment: 
    scope_by_role = {
    RoleConstants.WORKSPACE_MANAGE: PermissionScopeConstants.WORKSPACE,
    RoleConstants.USER: PermissionScopeConstants.WORKSPACE_RESOURCE,
}
    This reduces the risk of future role/scope misalignment.

Overall: no syntax problem in the diff, and the duplicate-scope fix is reasonable, but verify the intended mapping and downstream authorization behavior before merging.

Expand Down
Loading