Repository navigation
malformed hintsfile parsing - #11
Merged
rustaceanrob merged 2 commits intoOct 14, 2026
Merged
Conversation
Add an 11-byte regression test expecting an error. Currently, parsing panics when ilog2() is called on zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed hintsfiles can cause the parser to panic instead of returning an error.
This was verified during Floresta swift-sync work, where a malformed hintsfile caused the node to panic. As a library,
hintsfileideally should report malformed input through theResultAPI so callers can handle the failure gracefully.This PR updates the parser to return
InvalidDatafor unsupported compact-size prefixes, invalid Elias-Fano parameters and inconsistent high-bit counts. Public signatures remain unchanged.The first commit 4bd9472 adds a regression test that reproduces the parser panic.