Do not ignore SKIP as a new test result after re-test#23
Open
miczyg1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Member
Author
|
Simple test: Commands: |
philipanda
reviewed
May 8, 2026
| if old is None: | ||
| test.message = self._create_add_message(test) | ||
| self.current.tests.append(test) | ||
| elif test.skipped: |
There was a problem hiding this comment.
Maybe make it conditional using a flag passed to rebot?
This way there would be less friction in future rebases of the fork.
Member
Author
There was a problem hiding this comment.
Suggestions to the flag name?
| Test merge should have been successful suite name=Custom | ||
| Log should have been created with Fail keywords flattened | ||
|
|
||
| Merge ignores skip |
There was a problem hiding this comment.
The test fails for me:
----------------------------------------------------------------------------------------------------
FAIL: Robot.Rebot.Merge.Merge skip result
Evaluating expression "'Test skipped using 'NOT skip' tag pattern.' != ''" failed: SyntaxError: invalid syntax (<string>, line 1)
----------------------------------------------------------------------------------------------------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem where unsupported/skipped tests in rerun would not get their state updated from FAIL to SKIP.