Repository navigation
Complete Select control attributes and selection coverage - #50
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the remaining acceptance criteria for native Select attributes and multiple-dropdown selection after #48 and #49.
Add DOM-based regression coverage for single/multiple selection, unmatched and numeric values, mode switching, submitted names, control attributes, wrapper/label targeting, and native group semantics. Prevent
inputProps()from overriding explicit selection modes or checked values throughmultipleandcheckedattributes.Document attribute precedence, PHP array naming, fieldset disabling, and the distinction between radio-group required validation and requiring every checkbox.
Validation:
composer productionpassed (source style, PHPStan, and 167 tests / 1,628 assertions on PHP 8.5.2);git --no-pager diff --checkpassed.List of issues fixed
Fixes #46