Repository navigation
test(ci): isolate custody-test Action summaries from GitHub job summary - #187
Merged
Merged
Conversation
aetherxeg-source
marked this pull request as ready for review
October 9, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
During an approved external-contributor CI run for PR #128, the GitHub job summary displayed five
ExecSurface — ERRORreports and onePASSeven though every CI step and Rust test passed. Those are the intentional negative and positive cases ofr4_action_custody.rs; they were not failures in the PR under review.Root cause
r4_action_custody.rs::run_actionlaunchesaction/run.shas a child process without overriding the inheritedGITHUB_STEP_SUMMARY. The Action intentionally appends its report to that path. During GitHub-hostedcargo test, the six fixture runs therefore append five expectedERRORand one expectedPASSsections to the unrelated parent job summary.Focused change
GITHUB_STEP_SUMMARYto a test-local file.Review gates
cargo fmt, strict clippy, all Rust tests, lockfile integrity.ExecSurface — ERRORblocks.Relevant source:
crates/execsurface-cli/tests/r4_action_custody.rsandaction/run.sh.This PR is independent of external contributor PR #128 and does not modify or silently change its evidence or merge qualification.