Add VBench benchmarking suite and scripts - #475
jitendra-jalwaniya wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a VBench evaluation workflow for MaxDiffusion, specifically tailored for Wan text-to-video models. It adds TPU generation and GPU evaluation scripts, utility helpers, and a downsampled 110-prompt benchmark dataset. The feedback suggests improving the robustness and portability of the scripts by using POSIX-compliant disk space checks, always enforcing virtual environment creation to avoid PEP 668 issues, and explicitly specifying UTF-8 encoding when reading and writing files.
9f9995d to
83dd965
Compare
83dd965 to
92766c9
Compare
There was a problem hiding this comment.
This is just a lint fix, unintentional change from last PR.
mbohlool
left a comment
There was a problem hiding this comment.
Here is a code review covering items 1 through 9 for the VBench benchmarking suite integration:
92766c9 to
d0ba84c
Compare
Overview
This PR introduces a standardized
benchmarks/framework to MaxDiffusion, starting with the VBench video-generation benchmark integration. It provides an end-to-end, two-stage evaluation pipeline tailored for Wan text-to-video (T2V) models: generating videos on Google Cloud TPU and evaluating quality dimensions on GPU.Key Changes
1. Benchmark Framework & Documentation
benchmarks/README.md: Establishes the organizational guidelines for adding runnable benchmark suites and evaluation metadata across models.benchmarks/vbench/README.md: Detailed workflow documentation, parameter references, and usage examples for running locally or remotely via SSH.2. Dataset & Metadata
benchmarks/vbench/prompts_110.txt: A curated 110-prompt downsampled subset from the VBench benchmark.benchmarks/vbench/VBench_full_info_sub110.json: Aligned evaluation metadata covering all relevant VBench quality and semantic dimensions corresponding 1-to-1 with the prompt file.3. Generation & Evaluation Automation
benchmarks/vbench/run_tpu_generation.sh:--ssh).gs://<bucket>/<run-name>/videos.benchmarks/vbench/run_gpu_eval.sh:--ssh).gs://<bucket>/<run-name>/vbench_results(handles SSH credential passthrough without requiring GPU VM GCS service account scopes).benchmarks/vbench/gpu_eval_utils.py:Workflow
How to Test
1. TPU Generation
Direct on TPU or remote via SSH:
2. GPU Evaluation
Direct on GPU or remote via SSH:
3. Python Helper Verification