fix(deps): skip nvidia-cuda-cccl on macOS (no wheels available) - #476
Open
harkanwalbedi wants to merge 2 commits into
Open
harkanwalbedi wants to merge 2 commits into
harkanwalbedi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request excludes the nvidia-cuda-cccl dependency on macOS by adding an environment marker to the generated requirements file. The reviewer correctly pointed out that manually editing an autogenerated file introduces a maintenance risk as it will be overwritten during the next regeneration, and recommended applying this change to the source requirements file instead.
Perseus14
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pip install -e ".[dev]"fails on macOS ARM64 / Apple Silicon (reported in #393):nvidia-cuda-ccclonly publishesmanylinuxand Windows wheels — no macOS wheels exist — so requiring it unconditionally blocks local developer installs on macOS.Root Cause
The generated lockfile pinned
nvidia-cuda-cccl>=13.1.115without an environment marker. It is the only NVIDIA package in the lockfile, and no direct dependency requires it unconditionally, so this appears to be a transitive dependency captured during lock resolution on a Linux/CUDA host that lost its platform scoping.Fix
Add an environment marker matching the package's actual wheel availability:
This mirrors the existing treatment of
libtpuin the same file (line 92:sys_platform == 'linux') and leaves Linux, Windows, and CI resolution completely untouched.Verification
Tested on physical hardware (Apple M4 Pro, macOS Sequoia arm64):
pip install -e ".[dev]"failed withNo matching distribution found for nvidia-cuda-cccl>=13.1.115.nvidia-cuda-ccclon Darwin, resolving dependencies without platform failure.Fixes #393