Fix nightly and stable Docker image build pipeline - #481
Open
prishajain1 wants to merge 1 commit into
Open
prishajain1 wants to merge 1 commit into
prishajain1 wants to merge 1 commit into
Conversation
- Switch base image from deprecated python:3.12-slim-bullseye to python:3.12-slim-bookworm - Replace retired google-cloud-sdk apt package with google-cloud-cli - Add if: always() to nightly build step in UploadDockerImages.yml so a stable build failure does not silently skip nightly publishing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the base Docker image from Debian Bullseye (python:3.12-slim-bullseye) to Debian Bookworm (python:3.12-slim-bookworm) in both the build script and the dependencies Dockerfile. Additionally, it replaces the installation of the retired google-cloud-sdk package with google-cloud-cli. There are no review comments, and I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nightly and stable Docker image builds in
.github/workflows/UploadDockerImages.ymlwhich have been failing since 2026-08-28.Root Causes
python:3.12-slim-bullseyeis deprecated / EOL, causing Debian package archive mirrors to fail whenapt-get updateruns.google-cloud-sdkhas been retired by Google Cloud apt repositories in favor ofgoogle-cloud-cli.UploadDockerImages.ymlran the nightly build step unconditionally only if the preceding stable build succeeded (steps.build_stablefailure skippedsteps.build_nightly).Changes
maxdiffusion_dependencies.Dockerfileanddocker_build_dependency_image.shdefaultBASEIMAGEfrompython:3.12-slim-bullseyetopython:3.12-slim-bookworm.apt-get installinmaxdiffusion_dependencies.Dockerfileto installgoogle-cloud-cliinstead ofgoogle-cloud-sdk.if: always()to the nightly image build step in.github/workflows/UploadDockerImages.ymlso that nightly images continue to publish even if stable build encounters an independent issue.