Integrate sharded Muon into MaxText. - #5120
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
September 3, 2026 03:39
copybara-service
Bot
force-pushed
the
test_975384637
branch
from
September 3, 2026 04:02
014e648 to
b68bee2
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Implements sharded_muon_utils.py to pair Muon dimension numbers paired with NamedSharding trees.
- Adds flags for muon_type ('maxtext_muon' vs 'optax_muon') and muon_use_all_to_all.
- Plumbs mesh through create_training_optimizer in train_utils.py, train_compile.py, and maxtext_engine.py. This is necessary to make sharded muon work.
- Adds comprehensive unit test coverage.
PiperOrigin-RevId: 975384637
copybara-service
Bot
force-pushed
the
test_975384637
branch
from
September 3, 2026 04:08
b68bee2 to
1225e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate sharded Muon into MaxText.