Repository navigation
Add Android CMake build coverage - #9
Open
federicobozzini wants to merge 2 commits into
Open
federicobozzini wants to merge 2 commits into
federicobozzini wants to merge 2 commits into
Conversation
gmiodice
reviewed
Nov 12, 2026
gmiodice
reviewed
Nov 12, 2026
| grep -qx "COMPUTE_FLOW_BUILD_${dependency}_FROM_SOURCE:BOOL=OFF" "$cache" | ||
| done | ||
| - name: Build with CMake | ||
| run: uv run cmake --build build_android_arm64 --parallel "$CMAKE_BUILD_PARALLEL_LEVEL" |
Contributor
There was a problem hiding this comment.
Why don't we use the brick manager build command?
compute-flow build android_arm64
Contributor
There was a problem hiding this comment.
Can we also check that we use the brick manager to build natively?
compute-flow build native
gmiodice
reviewed
Nov 12, 2026
Contributor
|
It looks ok |
gmiodice
previously approved these changes
Nov 13, 2026
federicobozzini
dismissed
gmiodice’s stale review
November 13, 2026 11:34
The merge-base changed after approval.
federicobozzini
force-pushed
the
android-cmake
branch
from
November 13, 2026 11:34
3e7ce40 to
8970fa3
Compare
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
federicobozzini
force-pushed
the
android-cmake
branch
from
November 13, 2026 11:51
8970fa3 to
5a8433f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.