Skip to content

End-to-end helpers on the generated client; flows for status, tasks, users, groups and roles - #117

Merged
aevnsvi merged 4 commits into
mainfrom
e2e-on-generated-client
Nov 19, 2026
Merged

aevnsvi merged 4 commits into
mainfrom
e2e-on-generated-client

Conversation

@aevnsvi

@aevnsvi aevnsvi commented Nov 19, 2026

Copy link
Copy Markdown

The end-to-end support code now builds its requests from the generated client's URL builders and types, sent through Playwright's request context, and the specs share one copy of each helper.

  • e2e/support/sdk-request.ts: typed GET, POST, PATCH, DELETE and multipart calls; a builder's leading double slash is collapsed before the request is sent
  • e2e/support/api.ts set-up and clean-up run on them; clean-up also deletes the users and groups of a run by their prefix
  • e2e/support/session.ts: signed-out state, login through the API for a given account and the permissions-read matcher, replacing copies in the remote, shell and smoke specs
  • New remote flows for the migrated screens: tasks (list, status filter, own address, old address), users, groups (members and roles) and roles; the limited account's Status screen
  • The smoke project opens a task at its own address and checks the old address, also for a task that does not exist

The remote flows run against a deployment given by the environment; here they type-check and are listed.

- Add e2e/support/sdk-request.ts: typed GET, POST, PATCH, DELETE and
  multipart calls on Playwright's request context, taking the address
  from a generated URL builder or a server href and collapsing the
  leading double slash a builder returns for an href
- Move the set-up and clean-up helpers of api.ts onto them; endpoint
  tables, task reads and uploads use the generated builders and types
- Let the delete spec name its endpoints through the builders
- Add e2e/support/session.ts with the signed-out state, the login
  through the API for a given account and the matcher for the answer
  that tells the page what the account may do; the remote, shell and
  smoke specs use it instead of their own copies
- Read through the typed helpers in the specs that built their own
  requests (paging, status, role and repository reads) and name the
  endpoints through the generated URL builders
- Let clean-up find and delete users and groups of a run by their
  prefix, as it already does for repositories and roles
- Take the storage state paths of the Playwright projects from
  storageStatePath
- Remote admin flows: a task from the list through the status filter
  to its own address and the old address ending on it; users created,
  edited and deleted; a group created with a member and a role, the
  role removed and the group deleted; a role created, edited and
  deleted
- Status shows the administrator workers, storage and content
  settings, and shows the limited account versions only
- The smoke project opens a task at its own address from the list and
  checks the old address, also for a task that does not exist
The application writes the task address as /tasks/<id>/ (every route
path ends with a slash), so a link or address pattern that ends at the
id never matched.
@aevnsvi
aevnsvi merged commit 5f4e93d into main Nov 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant