Repository navigation
End-to-end helpers on the generated client; flows for status, tasks, users, groups and roles - #117
Merged
Merged
Conversation
- Add e2e/support/sdk-request.ts: typed GET, POST, PATCH, DELETE and multipart calls on Playwright's request context, taking the address from a generated URL builder or a server href and collapsing the leading double slash a builder returns for an href - Move the set-up and clean-up helpers of api.ts onto them; endpoint tables, task reads and uploads use the generated builders and types - Let the delete spec name its endpoints through the builders
- Add e2e/support/session.ts with the signed-out state, the login through the API for a given account and the matcher for the answer that tells the page what the account may do; the remote, shell and smoke specs use it instead of their own copies - Read through the typed helpers in the specs that built their own requests (paging, status, role and repository reads) and name the endpoints through the generated URL builders - Let clean-up find and delete users and groups of a run by their prefix, as it already does for repositories and roles - Take the storage state paths of the Playwright projects from storageStatePath
- Remote admin flows: a task from the list through the status filter to its own address and the old address ending on it; users created, edited and deleted; a group created with a member and a role, the role removed and the group deleted; a role created, edited and deleted - Status shows the administrator workers, storage and content settings, and shows the limited account versions only - The smoke project opens a task at its own address from the list and checks the old address, also for a task that does not exist
The application writes the task address as /tasks/<id>/ (every route path ends with a slash), so a link or address pattern that ends at the id never matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end support code now builds its requests from the generated client's URL builders and types, sent through Playwright's request context, and the specs share one copy of each helper.
The remote flows run against a deployment given by the environment; here they type-check and are listed.