-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/4 implement skill pr review #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miroslavpojer
wants to merge
10
commits into
master
Choose a base branch
from
feature/4-implement-skill-pr-review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
677b52d
Implement token-saving skill and related evaluation files; update REA…
miroslavpojer e709f12
Add title parameter to release notes presence check in PR workflow
miroslavpojer f653b27
Update documentation for token-saving skill; add contribution guideli…
miroslavpojer fd9f957
Add token-saving skill documentation with response formatting rules
miroslavpojer e29e1bd
Add evaluation results summary, trigger evaluation data, and new scri…
miroslavpojer 3dce2b5
Enhance PR review skill documentation with additional checks for skil…
miroslavpojer b808333
Refactor PR review skill documentation and evaluation criteria; add n…
miroslavpojer a73b8f9
Merge remote-tracking branch 'origin/master' into feature/4-implement…
miroslavpojer 1a1ec7a
Fix review comments.
miroslavpojer 97a5932
Remove unused GitHub workflow for checking PR release notes; update f…
miroslavpojer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| # PR Review Skill | ||
|
|
||
| The `pr-review` skill performs structured, risk-aware code review on pull requests and diffs. It activates automatically when you ask for PR feedback, share a diff, or ask for a sanity check on changes. | ||
|
|
||
| --- | ||
|
|
||
| ## What it does | ||
|
|
||
| The skill reads the list of files changed in a PR, selects the relevant review sections, and produces a concise review grouped by severity: | ||
|
|
||
| | Severity | Meaning | | ||
| |----------|---------| | ||
| | **Blocker** | Must be fixed before merge — correctness bug, security vulnerability, broken contract, credentials in code, data loss risk | | ||
| | **Important** | Should be fixed soon — increases risk, missing tests for changed logic, non-default that's hard to change later | | ||
| | **Nit** | Minor polish — style, naming, optional improvement, non-urgent edge case | | ||
|
|
||
| If a section has no findings, the skill writes `_None._` to show it was checked, not skipped. | ||
|
|
||
| --- | ||
|
|
||
| ## Sections | ||
|
|
||
| The skill always applies **Standard review** and selects additional sections based on the files the PR touches: | ||
|
|
||
| | Section | Triggers when PR touches | | ||
| |---|---| | ||
| | Standard | Always applied | | ||
| | API contracts | Endpoints, DTOs, config keys, env vars, exit codes, output strings | | ||
| | Dependency bumps | `pom.xml`, `requirements.txt`, `pyproject.toml`, `package.json`, `*.csproj`, `go.mod`, `build.sbt` | | ||
| | CI/CD | `.github/workflows/`, `Jenkinsfile`, `Justfile`, `Makefile` (pipeline), deployment jobs | | ||
| | Infrastructure | `*.tf`, `*.tfvars`, CloudFormation, Helm, Dockerfiles, `docker-compose.yml`, `iac/`, `infra/` | | ||
| | DB migrations | `alembic/`, `flyway/`, `liquibase/`, `migrations/`, `*.sql`, `db/` | | ||
| | Skill definitions | `skills/*/SKILL.md`, any `SKILL.md` | | ||
| | Elevated risk | Overlay — applied on top when PR touches auth/security controls, secrets management, or infrastructure/external integrations | | ||
|
|
||
| A file may match multiple sections — all matching sections are applied. | ||
|
|
||
| --- | ||
|
|
||
| ## How to trigger it | ||
|
|
||
| Ask for a review naturally — the skill fires on intent, not exact wording: | ||
|
|
||
| ``` | ||
| review my PR | ||
| any issues with these changes? | ||
| LGTM? | ||
| does this look right? | ||
| check this diff for risks | ||
| can you review this before I merge? | ||
| ``` | ||
|
|
||
| You can also share a GitHub PR link directly: | ||
|
|
||
| ``` | ||
| https://github.com/org/repo/pull/123 — does this look safe to merge? | ||
| ``` | ||
|
|
||
| > **Does NOT trigger** for generative tasks on a diff: "generate release notes from this diff", "summarise this diff". Those are documentation tasks. | ||
|
|
||
| --- | ||
|
|
||
| ## Helpers | ||
|
|
||
| The skill ships two scripts to speed up data gathering: | ||
|
|
||
| | Script | Purpose | | ||
| |--------|---------| | ||
| | `scripts/fetch_pr.sh <PR_NUMBER>` | Fetches the diff and file list via `gh` | | ||
| | `scripts/classify_sections.py /tmp/pr_files.txt` | Prints which sections to apply given a file list | | ||
|
|
||
| These require the [GitHub CLI](https://cli.github.com/) (`gh`) to be authenticated. | ||
|
|
||
| --- | ||
|
|
||
| ## Overriding or scoping the review | ||
|
|
||
| You can narrow or redirect the review with natural language: | ||
|
|
||
| ``` | ||
| focus only on security issues | ||
| skip the nits — just blockers and importants | ||
| review only the migration files | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## Installation | ||
|
|
||
| The skill is installed along with the rest of the toolkit: | ||
|
|
||
| ```bash | ||
| npx skills add https://github.com/AbsaOSS/agentic-toolkit -g | ||
| ``` | ||
|
|
||
| To install only this skill: | ||
|
|
||
| ```bash | ||
| npx skills add https://github.com/AbsaOSS/agentic-toolkit -g --skill pr-review | ||
| ``` | ||
|
|
||
| See [Getting Started](./getting-started.md) for the full install guide. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.