Skip to content

feat: fix a11y issues in progress circular component#667

Merged
fateeand merged 10 commits into
masterfrom
592-fix-a11y-issues-in-progress-circular-component
Jun 17, 2026
Merged

feat: fix a11y issues in progress circular component#667
fateeand merged 10 commits into
masterfrom
592-fix-a11y-issues-in-progress-circular-component

Conversation

@fateeand

@fateeand fateeand commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Fixing accessibility issues in progress circular component

Validation rules:

Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.

Full doc with rules


Playwright axe-core validation results:

State before:

Notification aria-roles
Progress circular -

State after:

Notification aria-roles
Progress circular

Checklist

  • [N/A] Keyboard Navigation
    All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.

  • [N/A] Focus Management
    Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.

  • Semantics / ARIA

    • Semantic HTML is used correctly.
    • ARIA roles, states, and properties are applied only when needed.
    • All form fields, tables, and widgets (including autocomplete, tree selects, tree tables, drag-and-drop, sliders, and multi-selects) are properly labeled and accessible.
  • Color / Contrast

    • Text and interactive elements meet contrast requirements (≥4.5:1 normal text, ≥3:1 large text).
    • Focus and selection indicators are visually perceivable.
    • Color is not the only indicator of state.
  • Screen Reader / Assistive Technology

    • All content, labels, and dynamic updates are perceivable via screen readers.
    • Live regions announce status messages, alerts, modals, notifications, and dynamic changes.
    • Interactive widgets provide proper announcements of selection and updates.
  • Responsive & Zoom

    • Components function correctly and remain readable at all viewport sizes and up to 200% zoom, including mobile and touch devices.
    • Prefer em/rem units over px where scaling is required.
  • [N/A] Error Handling

    • Errors are clearly identified visually and programmatically.
    • Form inputs use aria-describedby or aria-invalid for inline messages.
    • Instructions and suggestions are accessible.
  • [N/A] Dynamic Content / Updates

    • Status updates, alerts, notifications, and modals use live regions.
    • Updates do not disrupt focus or user control unexpectedly.
  • [N/A] Interaction Feedback / States

    • All interactive states (hover, focus, active, disabled, drag-and-drop, reordering, multi-select) are visually perceivable.
  • [N/A] Authentication & Sensitive Actions

    • Inputs and actions involving sensitive data provide accessible instructions, feedback, and error messages.
  • [N/A] Predictable & Controllable UI

    • Components behave consistently and predictably.
    • Popups, modals, autocomplete suggestions, drag-and-drop, and dynamic content allow user control.

Release notes:

  • Fix a11y issues in progress circular component

@fateeand fateeand linked an issue Jun 11, 2026 that may be closed by this pull request
@fateeand fateeand requested a review from lukasmatta as a code owner June 11, 2026 16:20
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Coverage report for library

St.
Category Percentage Covered / Total
🔴 Statements 50.02% 3728/7453
🔴 Branches 45.33% 1671/3686
🔴 Functions 49.44% 707/1430
🔴 Lines 50.63% 3479/6871

Test suite run success

1334 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from be94fea

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  98 passed

Details

stats  98 tests across 4 suites
duration  3 minutes, 22 seconds
commit  be94fea
info  For details, download the Playwright report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the accessibility of CpsProgressCircularComponent by ensuring it has the correct ARIA semantics (role + accessible name), and updates downstream usages/docs/tests so the component passes automated accessibility scans.

Changes:

  • Add role="progressbar" and an ariaLabel API (with a “Loading” fallback) to cps-progress-circular.
  • Stop mutating input values by introducing converted/display properties (cvtDiameter, cvtStrokeWidth, cvtColor) and update templates/usages to use rem-based sizing.
  • Expand unit test coverage for a11y behavior and re-enable Playwright a11y scanning for the progress circular route.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.ts Adds host role + aria-label behavior; refactors input conversion to converted properties.
projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.html Uses converted sizing/color values and hides decorative inner element from AT.
projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.spec.ts Updates defaults expectations; adds aria-label/role tests.
projects/cps-ui-kit/src/lib/components/cps-menu/cps-menu.component.html Updates spinner sizing to rem-based values.
projects/cps-ui-kit/src/lib/components/cps-button/cps-button.component.html Updates spinner stroke width to rem-based value.
projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.ts Adds CpsIconComponent import for the updated docs page content.
projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.scss Reworks layout/styling for the informational callout and spacing.
projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.html Updates example sizes to rem; adds an informational callout.
projects/composition/src/app/api-data/cps-progress-circular.json Updates documented defaults and documents the new ariaLabel input.
playwright/cps-accessibility.spec.ts Re-enables progress circular in the a11y component matrix.

@fateeand fateeand merged commit e9d6438 into master Jun 17, 2026
11 checks passed
@fateeand fateeand deleted the 592-fix-a11y-issues-in-progress-circular-component branch June 17, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix a11y issues in progress circular component

3 participants