feat: fix a11y issues in progress circular component#667
Merged
fateeand merged 10 commits intoJun 17, 2026
Conversation
Contributor
Coverage report for library
Test suite run success1334 tests passing in 37 suites. Report generated by 🧪jest coverage report action from be94fea |
Contributor
Playwright test resultsDetails
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility of CpsProgressCircularComponent by ensuring it has the correct ARIA semantics (role + accessible name), and updates downstream usages/docs/tests so the component passes automated accessibility scans.
Changes:
- Add
role="progressbar"and anariaLabelAPI (with a “Loading” fallback) tocps-progress-circular. - Stop mutating input values by introducing converted/display properties (
cvtDiameter,cvtStrokeWidth,cvtColor) and update templates/usages to use rem-based sizing. - Expand unit test coverage for a11y behavior and re-enable Playwright a11y scanning for the progress circular route.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.ts | Adds host role + aria-label behavior; refactors input conversion to converted properties. |
| projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.html | Uses converted sizing/color values and hides decorative inner element from AT. |
| projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.spec.ts | Updates defaults expectations; adds aria-label/role tests. |
| projects/cps-ui-kit/src/lib/components/cps-menu/cps-menu.component.html | Updates spinner sizing to rem-based values. |
| projects/cps-ui-kit/src/lib/components/cps-button/cps-button.component.html | Updates spinner stroke width to rem-based value. |
| projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.ts | Adds CpsIconComponent import for the updated docs page content. |
| projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.scss | Reworks layout/styling for the informational callout and spacing. |
| projects/composition/src/app/pages/progress-circular-page/progress-circular-page.component.html | Updates example sizes to rem; adds an informational callout. |
| projects/composition/src/app/api-data/cps-progress-circular.json | Updates documented defaults and documents the new ariaLabel input. |
| playwright/cps-accessibility.spec.ts | Re-enables progress circular in the a11y component matrix. |
lukasmatta
reviewed
Jun 16, 2026
lukasmatta
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing accessibility issues in progress circular component
Validation rules:
Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.
Full doc with rules
Playwright axe-core validation results:
State before:
State after:
Checklist
[N/A] Keyboard Navigation
All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.
[N/A] Focus Management
Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.
Semantics / ARIA
Color / Contrast
Screen Reader / Assistive Technology
Responsive & Zoom
[N/A] Error Handling
[N/A] Dynamic Content / Updates
[N/A] Interaction Feedback / States
[N/A] Authentication & Sensitive Actions
[N/A] Predictable & Controllable UI
Release notes: