#3 Fix: Use an intermediate environment variable#8
Open
ndivho-makhuvha wants to merge 3 commits into
Open
Conversation
ndivho-makhuvha
requested review from
miroslavpojer and
oto-macenauer-absa
as code owners
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the composite action’s shell-injection risk by passing action inputs through environment variables before consuming them in Bash.
Changes:
- Adds
env:bindings forcertificatesandwarning_days. - Adds input validation for
warning_daysand JSON array structure. - Attempts to replace direct
${{ inputs.* }}usage in the Bash script.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
oto-macenauer-absa
approved these changes
May 29, 2026
Collaborator
oto-macenauer-absa
left a comment
oto-macenauer-absa
left a comment
There was a problem hiding this comment.
lgtm, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This contribution fixes a shell injection risk by using use of intermediate environment variables.
Release Notes
${{ inputs.* }}interpolation inside therun:block$INPUT_CERTIFICATES,$INPUT_WARNING_DAYS) already bound safely via theenv:blockRelated
Closes #3