feat(iconvert): allow -o for convenience#5173
Merged
Merged
Conversation
iconvert was the very first command line utility for OIIO, and its syntax was just `iconvert [options] infile outfile`. YEARS later, oiiotool came along, superceding iconvert with 100x the functionality, and also differed by requiring `-o` to specify output file. iconvert still exists for testing and examples -- iconvert uses just plain old ImageInput + ImageOutput straightforwardly, whereas oiiotool is a very complex app that's ImageBuf powered. It's often useful for debugging to test the ImageInput/ImageOutput layer without any extra complication, or to directly see how going through an ImageBuf might differ. The fact that oiiotool requires `-o` to specify an output file, whereas iconvert considers that an error, is a minor annoyance when switching back and forth while debugging, and it's really bugging me. So here it is, a tiny patch to let iconvert silently accept -o, or not, and do the obviously right thing. A little quality of life gift to myself. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Any comments? Will merge over the weekend if nobody objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconvert was the very first command line utility for OIIO, and its syntax was just
iconvert [options] infile outfile. YEARS later, oiiotool came along, superceding iconvert with 100x the functionality, and also differed by requiring-oto specify output file.iconvert still exists for testing and examples -- iconvert uses just plain old ImageInput + ImageOutput straightforwardly, whereas oiiotool is a very complex app that's ImageBuf powered. It's often useful for debugging to test the ImageInput/ImageOutput layer without any extra complication, or to directly see how going through an ImageBuf might differ.
The fact that oiiotool requires
-oto specify an output file, whereas iconvert considers that an error, is a minor annoyance when switching back and forth while debugging, and it's really bugging me.So here it is, a tiny patch to let iconvert silently accept -o, or not, and do the obviously right thing. A little quality of life gift to myself.