fix(zfile): check gzread returns for truncated or corrupt input - #5372
Open
lgritz wants to merge 1 commit into
Open
fix(zfile): check gzread returns for truncated or corrupt input#5372lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
The reader ignored gzread()'s return value when reading the header and each scanline, so a truncated or corrupt (gzip) file was processed with whatever happened to be in the buffer. Verify the requested number of bytes was actually read and error out otherwise. Also add a test for the decomression bomb checks that have already been added in a prior PR. Assisted-by: GitHub Copilot / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reader ignored gzread()'s return value when reading the header and each scanline, so a truncated or corrupt (gzip) file was processed with whatever happened to be in the buffer. Verify the requested number of bytes was actually read and error out otherwise.
Also add a test for the decompression bomb checks that have already been added in a prior PR.
Assisted-by: GitHub Copilot / Claude Opus 4.8