Skip to content

feat(color): Add g24_rec709_scene interop ID and use consistently - #5391

Open
brechtvl wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:color-interop-g24
Open

feat(color): Add g24_rec709_scene interop ID and use consistently#5391
brechtvl wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:color-interop-g24

Conversation

@brechtvl

Copy link
Copy Markdown
Contributor

Description

This was added in the CIF texture color space recommendation 1.1.

It was already used in PNG read and DPX. Now add in PNG write, TGA and RLA as well for consistency. Also fix wrong g22_rec709 and g18_rec709 without _scene suffix in TGA and RLA.

No matching CICP was added so g24_rec709_display continues to be the interop ID on read. Both for compatibility, and because that CICP is already ambiguous (now explained in a comment).

Ref #4980

Tests

Tests added to check for the presence of this interop ID.

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have read the Policy on AI Coding Assistants
    and if I used AI coding assistants, I have an Assisted-by: TOOL / MODEL
    line in the pull request description above.
  • I have updated the documentation if my PR adds features or changes
    behavior.
  • I am sure that this PR's changes are tested in the testsuite.
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.
  • If I added or modified a public C++ API call, I have also amended the
    corresponding Python bindings. If altering ImageBufAlgo functions, I also
    exposed the new functionality as oiiotool options.

This was added in the CIF texture color space recommendation 1.1.

It was already used in PNG read and DPX. Now add in PNG write,
TGA and RLA as well for consistency. Also fix wrong g22_rec709
and g18_rec709 without _scene suffix in TGA and RLA.

No matching CICP was added so g24_rec709_display continues to be
the interop ID on read. Both for compatibility, and because that
CICP is already ambiguous.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
@brechtvl

Copy link
Copy Markdown
Contributor Author

CC @zachlewis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant