fix(IBA): keep nearest resample off the Highway path - #5393
Open
wingfiring wants to merge 1 commit into
Open
Conversation
wingfiring
force-pushed
the
fix/resample-hwy-nearest
branch
2 times, most recently
from
August 10, 2026 21:27
6d0cf7a to
a49e3de
Compare
resample_hwy() ignores its `interpolate` argument and always bilerps, but resample_() routed nearest sampling to it whenever Highway was enabled, so ImageBufAlgo::resample(dst, src, false) returned filtered pixels instead of the source pixel the caller asked for. Measured against a 128x128 nearest resample of testsuite/common/grid.tif, 40.9% of pixels were wrong, with a maximum error of 0.608. Latent today because enable_hwy defaults to 0, but it becomes a live behavior change as soon as Highway is turned on by default. Also fixes an MSVC build failure in the same subsystem. The two hwy_*_perpixel_op_rgba_rgb_roi() lambdas derived a tag type with decltype(d), where d is captured from the enclosing function; MSVC yields a reference type there, and D::template Rebind<T> cannot be named through a reference. Naming the tag directly drops the dependency on how decltype treats a captured entity, and says what the tag is rather than what it matches. Signed-off-by: Jackson Sun <jackson.sun@autodesk.com>
wingfiring
force-pushed
the
fix/resample-hwy-nearest
branch
from
August 10, 2026 21:28
a49e3de to
b8293cb
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resample_hwy() ignores its
interpolateargument and always bilerps, but resample_() routed nearest sampling to it whenever Highway was enabled, so ImageBufAlgo::resample(dst, src, false) returned filtered pixels instead of the source pixel the caller asked for. Measured against a 128x128 nearest resample of testsuite/common/grid.tif, 40.9% of pixels were wrong, with a maximum error of 0.608.Latent today because enable_hwy defaults to 0, but it becomes a live behavior change as soon as Highway is turned on by default.
Also fixes an MSVC build failure in the same subsystem. The two hwy_*_perpixel_op_rgba_rgb_roi() lambdas derived a tag type with decltype(d), where d is captured from the enclosing function; MSVC yields a reference type there, and D::template Rebind cannot be named through a reference. Naming the tag directly drops the dependency on how decltype treats a captured entity, and says what the tag is rather than what it matches.
Tests
Case added: test_resample_hwy_nearest
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.