Skip to content

feat(color): Add srgb_rec709_display as a built-in color space - #5396

Open
brechtvl wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:color-interop-builtin-srgb
Open

feat(color): Add srgb_rec709_display as a built-in color space#5396
brechtvl wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:color-interop-builtin-srgb

Conversation

@brechtvl

@brechtvl brechtvl commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

srgb_rec709_display is now a built-in color space alongside srgb_rec709_scene, and config color spaces like "sRGB - Display" are now classified as such. The built-in sRGB name remains an alias of srgb_rec709_scene.

This means it can be relied on to be available, even when using an OCIO config that does not contain it. And is on equal footing with srgb_rec709_scene in case it becomes the default in the future.

Tests

Added some tests to detect the presence of this.

Warning

The test output will change and need to be updated after #4971 or #5387 lands, as it will then find the matching color space in older configs.

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have read the Policy on AI Coding Assistants
    and if I used AI coding assistants, I have an Assisted-by: TOOL / MODEL
    line in the pull request description above.
  • I have updated the documentation if my PR adds features or changes
    behavior.
  • I am sure that this PR's changes are tested in the testsuite.
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.
  • If I added or modified a public C++ API call, I have also amended the
    corresponding Python bindings. If altering ImageBufAlgo functions, I also
    exposed the new functionality as oiiotool options.

srgb_rec709_display is now a built-in color space alongside
srgb_rec709_scene, and config color spaces like "sRGB - Display"
are now classified as such. The built-in sRGB name remains an alias of
srgb_rec709_scene.

This means it can be relied on to be available, even when using an
older OCIO config that does not contain it. And is on equal footing
with srgb_rec709_scene in case it becomes the default in the future.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
@brechtvl

Copy link
Copy Markdown
Contributor Author

CC @zachlewis

This is the last of my own changes I currently hope to get into 3.2, to make the display interop ID support somewhat complete. In the sense that when it's encountered from e.g. a user input or colorInteropID it should work equally well as the corresponding scene referred interop ID, but without yet making it the default guess when reading files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant