feat(color): Add srgb_rec709_display as a built-in color space - #5396
Open
brechtvl wants to merge 1 commit into
Open
feat(color): Add srgb_rec709_display as a built-in color space#5396brechtvl wants to merge 1 commit into
brechtvl wants to merge 1 commit into
Conversation
srgb_rec709_display is now a built-in color space alongside srgb_rec709_scene, and config color spaces like "sRGB - Display" are now classified as such. The built-in sRGB name remains an alias of srgb_rec709_scene. This means it can be relied on to be available, even when using an older OCIO config that does not contain it. And is on equal footing with srgb_rec709_scene in case it becomes the default in the future. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Contributor
Author
|
CC @zachlewis This is the last of my own changes I currently hope to get into 3.2, to make the display interop ID support somewhat complete. In the sense that when it's encountered from e.g. a user input or |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
srgb_rec709_displayis now a built-in color space alongsidesrgb_rec709_scene, and config color spaces like "sRGB - Display" are now classified as such. The built-insRGBname remains an alias ofsrgb_rec709_scene.This means it can be relied on to be available, even when using an OCIO config that does not contain it. And is on equal footing with
srgb_rec709_scenein case it becomes the default in the future.Tests
Added some tests to detect the presence of this.
Warning
The test output will change and need to be updated after #4971 or #5387 lands, as it will then find the matching color space in older configs.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.