Add zstd as a compression option for the OpenEXR plugin in OIIO - #5397
Open
TodicaIonut wants to merge 4 commits into
Open
Add zstd as a compression option for the OpenEXR plugin in OIIO#5397TodicaIonut wants to merge 4 commits into
TodicaIonut wants to merge 4 commits into
Conversation
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Signed-off-by: Todica Ionut <todicaionut2000111@gmail.com>
Collaborator
|
I think you have an error. (only the "bleeding edge" test is building against OpenEXR 'main', so that's the only one that's really enabling your changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding the new zstd compression codec to OpenEXR, here we enable it in the OIIO stack so it will be recognized by the library and binary tools, such as using oiiotool to directly change compression type into zstd.
I'm also trying to study if more changes on the OIIO side is required to enabled the new zstd codec throughout the OIIO tool chain... suggestions welcome.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.