Repository navigation
fix(ads): harden startup and retire ad-free passes - #34
Open
deadlyjack wants to merge 1 commit into
Open
deadlyjack wants to merge 1 commit into
deadlyjack wants to merge 1 commit into
Conversation
Bound iOS ATT and StoreKit startup waits, reject stale callbacks, and cache verified ad environments with a monotonic retry cooldown. Guard rewarded presentation recovery on both platforms and keep retries bounded. Remove new ad-free pass offers, redemption APIs, unused academy ad units, and related UI/translations while honoring previously earned time. Reuse one share service across bridge calls and fix native callback lifetime warnings and Alpine SDK cache invalidation. Prepare build 1023 and keep local review notes ignored. Validation before commit: 34 selected iOS native/bridge tests passed, including a final 14-test ATT/StoreKit rerun; unsigned device Release build succeeded. Earlier unchanged JS and Android suites passed. Formatting and staged whitespace checks pass. Physical TestFlight verification remains. BREAKING CHANGE: system.redeemReward and the retired ad-free-pass offer APIs/exports are removed; existing earned ad-free time remains valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound iOS ATT and StoreKit startup waits, reject stale callbacks, and cache verified ad environments with a monotonic retry cooldown. Guard rewarded presentation recovery on both platforms and keep retries bounded.
Remove new ad-free pass offers, redemption APIs, unused academy ad units, and related UI/translations while honoring previously earned time. Reuse one share service across bridge calls and fix native callback lifetime warnings and Alpine SDK cache invalidation. Prepare build 1023 and keep local review notes ignored.
Validation before commit: 34 selected iOS native/bridge tests passed, including a final 14-test ATT/StoreKit rerun; unsigned device Release build succeeded. Earlier unchanged JS and Android suites passed. Formatting and staged whitespace checks pass. Physical TestFlight verification remains.
BREAKING CHANGE: system.redeemReward and the retired ad-free-pass offer APIs/exports are removed; existing earned ad-free time remains valid.