Skip to content

fix: admob - #2684

Merged
bajrangCoder merged 1 commit into
mainfrom
fix/admob
Aug 7, 2026
Merged

fix: admob#2684
bajrangCoder merged 1 commit into
mainfrom
fix/admob

Conversation

@deadlyjack

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR releases Acode 1.12.9 and removes the policy-prohibited interstitial ad from the application exit flow.

  • Removes the exit-time AdMob helper call while preserving confirmation, state-saving callbacks, and application exit behavior.
  • Adds unit coverage for confirmed and cancelled exits and synchronous and asynchronous close callbacks.
  • Synchronizes the version across Cordova and npm metadata and documents the fix in the changelog.

Confidence Score: 5/5

The PR appears safe to merge because the removed helper only displayed an opportunistic ad and the required exit and state-saving behavior remains preserved.

The exit flow still performs confirmation, invokes synchronous or asynchronous close callbacks, and calls the native exit operation; the removed helper has no cleanup, persistence, or other required lifecycle side effects.

Important Files Changed

Filename Overview
src/lib/actionStack.js Removes only the opportunistic interstitial invocation from the exit path; confirmation, close callbacks, and final exit behavior remain intact.
tests/unit/actionStack.test.js Adds focused regression coverage proving exit flows do not invoke the ad helper and continue to handle confirmation and close callbacks correctly.
config.xml Updates the application version and Android version code consistently for the 1.12.9 release.
package.json Updates the package version to 1.12.9 without changing dependencies or scripts.
package-lock.json Keeps root lockfile package metadata synchronized with package.json.
CHANGELOG.md Documents removal of the policy-prohibited exit interstitial in version 1.12.9.

Reviews (1): Last reviewed commit: "fix: admob" | Re-trigger Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 341c027 Aug 7, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 7, 2026
@deadlyjack
deadlyjack deleted the fix/admob branch August 7, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants