Skip to content

feat(build): add no-terminal flag to omit embedded terminal assets #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xaniexane wants to merge 1 commit into from
+22 −2
Closed

feat(build): add no-terminal flag to omit embedded terminal assets #2916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions utils/scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
app="paid"
mode="d"
fdroidFlag=""
noTerminalFlag=""
packageType="apk" # New default: apk or aar
webpackmode="development"
cordovamode=""
Expand All @@ -19,6 +20,13 @@ for arg in "$@"; do
"fdroid")
fdroidFlag="fdroid"
;;
# Omit the embedded terminal rootfs (~90MB with Ubuntu) from the APK.
# For rapid dev-test iteration on capped connections; the terminal is
# unavailable in such builds. Example:
# npm run build paid dev apk no-terminal
"no-terminal")
noTerminalFlag="no-terminal"
;;
"apk"|"bundle")
packageType="$arg"
;;
Expand Down Expand Up @@ -57,8 +65,9 @@ else
echo "false" > "$tmpdir/fdroid.bool"
fi

# Add only if the src exists and not already installed
if [ -d "src/plugins/proot" ] && [ ! -d "plugins/com.foxdebug.acode.rk.exec.proot" ]; then
# Add only if the src exists and not already installed.
# Skipped for no-terminal builds: the rootfs is omitted (see below).
if [ "$noTerminalFlag" != "no-terminal" ] && [ -d "src/plugins/proot" ] && [ ! -d "plugins/com.foxdebug.acode.rk.exec.proot" ]; then
cordova plugin add src/plugins/proot/
fi

Expand All @@ -67,6 +76,17 @@ else
fi
fi

# Dev-test builds can skip the embedded terminal rootfs (see #2897): with the
# proot plugin removed, the heavy per-arch rootfs assets are never copied into
# the APK, keeping it small for capped connections and fast CI iteration.
# A subsequent normal build re-adds the plugin via the block above.
if [ "$noTerminalFlag" = "no-terminal" ]; then
echo "Building without embedded terminal assets: the terminal will be unavailable in this APK."
if [ -d "plugins/com.foxdebug.acode.rk.exec.proot" ]; then
cordova plugin remove com.foxdebug.acode.rk.exec.proot
fi
fi



# Normalize mode values
Expand Down