clippy 1.99: make the CI Lint job's clippy step clean

[AdaWorldAPI]

This is a follow-up to #180, which merged before this commit was pushed. It makes the clippy step of the CI: Master Lint job pass on the pinned 1.99.0 toolchain.

Verified with CI's exact command, cargo clippy --all-targets -- -D warnings -A unused -A dead-code …, which exits 0.

Changes

• chunks_exact(8) → as_chunks::<8>().0.iter(), 16 sites, from the new chunks_exact_to_as_chunks lint.
  • The loop now reads the [u8; 8] directly instead of calling try_into().unwrap().
  • graph/avx_engine.rs takes the remainder from as_chunks as well.
  • Behaviour is unchanged: a trailing remainder is still dropped.
• examples/heartbeat.rs still imported core::simd, which ced28ba removed. It now imports core::hamming_distance.
• Small fixes: removed a clone on a Copy type, a manual slice fill, a nested if let that can be the ? operator, a needless into_iter, and a no-op | 0u64. A 3.14 test literal tripped approx_constant, so it is now 2.5.
• Two scoped allows:
  • module_inception on the private spo/spo.rs reference module (CLAUDE.md §2).
  • field_reassign_with_default in the agent_state test module.
• rustfmt on the 8 files where my edits introduced formatting differences: the DataFusion 54 port in src/query/* and the as_chunks sites.
  • The other formatting differences in the touched files are on main already, and I didn't change them.
  • cargo fmt --all --check can't run in a workspace whose sibling n8n-rs path-depends on rustynum/jitson. That needs a wasmtime fork that isn't cloned, so cargo metadata fails. I checked each file with rustfmt over stdin instead.

Tests

The library tests are re-running locally with RUST_MIN_STACK=64MiB. I'll post the comparison against the known failure set from main (27 failures) on this PR when the run finishes.

🤖 Generated with Claude Code

https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB

---

Generated by Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[AdaWorldAPI]

Unit Tests (all modules) and Proof Summary are red, but not because of this PR.

The library run aborts with a stack overflow in spo::codebook_training::tests::test_concept_learning. The same happens on main (see #180), and Proof Summary just reflects that job's failure.

I ran the library tests locally on this branch with RUST_MIN_STACK=64MiB. It gives 1455 passed / 27 failed, and the 27 failing tests are exactly the ones that fail on main, compared with diff on the sorted lists. That includes graph::avx_engine (its benches pass), where this PR changed the remainder handling. So the as_chunks rewrites change no test outcome.

The clippy step of the Lint job now exits 0, run with CI's exact flags.

---

Generated by Claude Code