Skip to content

Rust 1.98.1 → 1.99.0 (lgj-abi), aligned with the lance-graph / ndarray sweep - #91

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-edc85bd9-89tiwe
Oct 10, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-edc85bd9-89tiwe

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

  • native/lgj-abi/rust-toolchain.toml and rust-version move to 1.99.0, with a bump-log line.
  • The README no longer restates the Rust version. It now points at the toolchain file, which is the only place the version is kept. The README had drifted to 1.97.1.
  • .claude/knowledge/abi-ownership-and-handles.md records what the Rust 1.99 C-ABI changes do and do not change for this ABI:
    • New UnsafeCell guarantee: it does not change the soundness argument for the writable mask lane. Java writes into a boxed buffer, not inside the lock's UnsafeCell. The single production writer, importRows, writes a mask nobody else holds yet.
    • Concurrent Java writers: these would still need atomic words plus a protocol, as before.
    • C-variadic definitions: not applicable, since every export is fixed-arity.
    • no_mangle on generic items (now a hard error): none of the 30 exports are generic.

lgj-abi's dependency graph has no lance, lancedb or arrow, so the lance 13 / lancedb 0.40 part of the sweep does not reach this crate.

Merge order

Merge this PR before the ndarray and lance-graph 1.99 PRs (lance-graph #1437). CI checks those two out at main. Once they declare rust-version 1.99, a 1.98 build of this crate no longer resolves.

Verified locally (rustc 1.99.0, JDK 28+16 EA)

check result
cargo clippy --all-targets -D warnings and cargo test (lgj-abi) clean
cargo build --release with CI's rustflags (-D warnings -Ctarget-cpu=x86-64-v3) built
AllTests 612 checks passed (abi 0.12, ndarray::simd avx2)
consumer mains Bricks 70, GraphHop 68, TradesAllocation 3, TradesParity 12, all passed
TinkerPop harness (interop/tinkerpop) LoweringStrategyTest 55 passed

🤖 Generated with Claude Code

https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB


Generated by Claude Code

…ned)

Non-comment pins only (rust-toolchain.toml, rust-version, CI MSRV, Dockerfile
images); historical comments untouched. lance/lancedb moved in lockstep with
lance-graph (arrow 58 / datafusion 54 unchanged); lancedb 0.40.0 still needs
`remote` to compile. Verification results follow in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
AllTests 612 + consumers 153 green on JDK 28 against a 1.99-built .so;
lgj-abi clippy -D warnings clean. The UnsafeCell guarantee does not change
the writable-lane soundness argument (recorded in abi-ownership-and-handles).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 6a57290d-e83c-475b-9622-442d7061c787

📥 Commits

Reviewing files that changed from the base of the PR and between 0b835f1 and bd5e107.


📒 Files selected for processing (4)
  • .claude/knowledge/abi-ownership-and-handles.md
  • README.md
  • native/lgj-abi/Cargo.toml
  • native/lgj-abi/rust-toolchain.toml

 _____________________________________________________________________________________________________________________
< The average user doesn't give a damn what happens, as long as (1) it works and (2) it's fast. - Daniel J. Bernstein >
 ---------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 02:12
@AdaWorldAPI
AdaWorldAPI merged commit cb02972 into main Oct 10, 2026
4 of 5 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T02:13:02.159259Z bd5e107 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants