Repository navigation
glove-parity: multi-hop questions over the software graph (D-SAG-1-4) - #1521
Closed
AdaWorldAPI wants to merge 6 commits into
Closed
AdaWorldAPI wants to merge 6 commits into
AdaWorldAPI wants to merge 6 commits into
Conversation
Defect A (#1510): link() deduplicated edges on (src, rel, dst, tier), so a fact two methods share was owned by whichever wrote it first; when that method stopped reading the field its reprojection retracted the fact for everyone. ctx is now part of the key, and out()/capability() read facts once however many contexts wrote them. Defect B (#1510): project_compute never retracted the DAG it replaced, so a cyclic-then-acyclic reprojection kept the ComputeCycle refusal and the stale ComputesFrom edges. It now retracts its own class's compute edges and cycle verdict first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
The entries index takes the first id in the heading, so the entry read as a second D-SAG-1 and the structural check refused the duplicate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
SoftwareGraph::hops(start, path) walks a path of (relation, direction) hops, set semantics per hop. Each hop is one Quack program over the resident edge lanes, rel = R AND from IN (S), keeping its rows; the previous hop's survivors reach it as a value set the size of those survivors, read from the kept rows' other end. No hop reads a plane another program produced. An unknown start node is an error, never an empty answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
--write keeps an existing row's id, so the retitled entry still read as D-SAG-1; the row is regenerated from the heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1519; merge that first. Until it merges, this diff also shows #1519's commits.
What
SoftwareGraph::hops(start, path)follows a path of(relation, direction)hops through the software-awareness graph. Each hop returns a set: each node once, in node order.This is the operator's reading of chained hops: the masks of one query fold into one materialisation, and each hop is filtered at the source.
rel = R AND from IN (S), keeping its rows.Filter::in_u32), sized by those results and read from the other end of the kept rows. No hop reads a plane another program produced, so the chained-mask shape the repo forbids (QuackFilter::Semijoin's precondition) is never used.This unblocks the multi-hop questions D-SAG-1 had to leave open: who else reads a field this method reads, which claims stand behind its fields, and which programs share primitives.
Evidence
tests/awareness.rschecks four paths of up to four hops against a row loop over the edges:A second test checks that a hop path follows a reprojection, which depends on #1519's fix for defect A.
Each of these four disable runs turns the tests red:
Gates:
cargo testandcargo clippy --all-targets -D warningspass for the crate;cargo fmtis clean.Still open
A value set still reads every edge row. Skipping straight to the rows of the previous hop's results needs either:
filter()(D-TELEPORT-2, arm Db), orISS-WITNESSED-RANGE-DOES-NOT-ATTEST-PLANE-ORDER.Also in this push: the entries index row for #1519's
D-SAG-1Rentry is regenerated.--writekeeps an existing row's id, so the retitled entry still read asD-SAG-1. The same fix is on #1519.🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code