Repository navigation
board: correct five #1527 arc entries from the full PR bodies - #1528
Merged
Merged
Conversation
The #1527 entries were written from PR bodies cut to 22 lines and 230 characters. Re-read in full, five need correction lines (append-only, under each entry): - #1505: its body said every workflow pins v3; dir-sim-persist and identity did not, which is where the SIGILL appeared. The wheel pin and the arm64-safe Docker pins came in commit 12cdfde, not the body. The thinking-engine images moved from SSE2 to v3. - #1518: R2IL and_cmp_i32 survives on main too, not only MIN/MAX. - #1509: H1 was measured slower (603-617 us vs 348-379 us); no speed-up. - #1523: its stale-claims note is itself stale after #1524. - #1524: companion ndarray#359 and the rebuild target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 13, 2026 05:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I wrote the arc entries in #1527 from PR bodies that I had cut to 22 lines and 230 characters each, and treated that truncated text as evidence. I then re-read all 12 bodies in full with the Read tool. Five entries were wrong or incomplete.
PR_ARC_INVENTORY.mdis append-only, so each correction is a dated line under its entry; nothing is rewritten.Corrections
x86-64-v3. That was false:dir-sim-persist.ymlandidentity.ymlset noRUSTFLAGS, and that is where the SIGILL appeared. The wheel pin and the arm64-safe Docker pins are not in the body; they came in the second commit,12cdfde, as Codex fixes. Not recorded before: the thinking-engine images used to build at generic x86-64 (SSE2) and now build at v3.procs::and_cmp_i32and its test also survive onmain, not onlyMIN/MAX. Verified onmain.Checks
append_only_gate.pypasses; this PR only adds 5 lines.🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code