Repository navigation
board: record #1538 and #1540; resolve ISS-SUPERVISOR-RESPAWN-BACKOFF-NOT-APPLIED - #1542
Conversation
…-NOT-APPLIED D-NALP-3 shipped (#1538). The supervisor restart backoff is applied (#1540); the vertical-slice evidence table and ISSUES.md now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b7650eca6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## ISS-SUPERVISOR-RESPAWN-BACKOFF-NOT-APPLIED — a crashed consumer actor is respawned at once and the respawn is rescheduled forever (2026-10-13) | ||
|
|
||
| **Status:** OPEN. **Basis:** VERIFIED-IN-CODE (`crates/lance-graph-supervisor/src/supervisor.rs`, `RespawnG` arm); found by the codex review of #1536. | ||
| **Status:** RESOLVED 2026-10-13 by #1540 (merged `f2bf199`). The delayed cast is now the only respawn path and is scheduled from `ActorTerminated`; the `RespawnG` arm spawns once and does nothing if the slot is already live; the crash count is carried and restarts at 1 when the previous crash is more than five minutes old (spec §5.3); more than 10 crashes in that window escalate and the child stays down. TEST-PINNED in `tests/supervisor_respawn_backoff.rs` (one respawn per crash after its backoff; escalation; window reset), each disable-verified red. The bullets below describe the defect as found. **Was:** OPEN. **Basis:** VERIFIED-IN-CODE (`crates/lance-graph-supervisor/src/supervisor.rs`, `RespawnG` arm); found by the codex review of #1536. |
There was a problem hiding this comment.
The implementation in supervisor.rs:324-330 only resets the count when the gap from the immediately preceding crash exceeds five minutes; it does not count crashes within a rolling five-minute window as required by spec §5.3. For example, with one crash per minute, the eleventh crash occurs ten minutes after the first and no five-minute interval contains more than ten crashes, yet the count reaches 11 and lines 336-345 leave the child down. The quiet-gap test does not cover this case, so marking the issue resolved and claiming escalation only for crashes “in that window” hides a remaining supervisor outage condition.
Useful? React with 👍 / 👎.
2 participants
Board follow-up for the three PRs merged today. This PR changes no code.
PR_ARC_INVENTORY.md: new entries for D-NALP-3: NAL revision as one grouped cross-moment fold, keyed by evidential base #1538 (D-NALP-3, NAL revision as one grouped fold) and fix(supervisor): respawn a crashed consumer once, after its backoff #1540 (supervisor restart backoff). #1536 follow-up: pin ONA links, correct the supervisor backoff claim; board for #1536/#1537 #1539 only corrected docs: outer membrane, epoch graph and ONA folding IR assimilation #1536's docs, and docs: outer membrane, epoch graph and ONA folding IR assimilation #1536's entry already describes that, so it gets no entry of its own.LATEST_STATE.md: D-NALP-3: NAL revision as one grouped cross-moment fold, keyed by evidential base #1538, #1536 follow-up: pin ONA links, correct the supervisor backoff claim; board for #1536/#1537 #1539 and fix(supervisor): respawn a crashed consumer once, after its backoff #1540 added to the merged list. The "backoff not applied" note under docs: outer membrane, epoch graph and ONA folding IR assimilation #1536 is removed.STATUS_BOARD.md: D-NALP-3 moves from In PR to Shipped (4ceaab3). The row now says the W3 test file has 11 tests and records the documented divergence from ONA.ISSUES.md:ISS-SUPERVISOR-RESPAWN-BACKOFF-NOT-APPLIEDis RESOLVED by fix(supervisor): respawn a crashed consumer once, after its backoff #1540 (f2bf199). The original defect bullets stay as history.OUTER_MEMBRANE_GRAPH_LAB_VERTICAL_SLICE.md: the Restart backoff row now says Applied (fix(supervisor): respawn a crashed consumer once, after its backoff #1540).entries_index.py --checkpasses.SUPERSESSION-INDEX.mdwas regenerated and did not change.🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code