Repository navigation
[harvest — do not merge] nal W4 (D-NALP-4): exact truth-law oracle and measurement, kept as a reminder - #1544
AdaWorldAPI wants to merge 3 commits into
Conversation
tests/w4.rs pins the exact integer law (round once, half up) for deduction, analogy, induction and abduction against hand-computed codes, OpenNARS nal1.1 and causal_edge::isa::truth (within one code). examples/w4_truth_law_probe.rs measures four realizations over all 2^32 inputs per law: only integer-valued f64 is exact everywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…-12) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa6c572f46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
127.5 rounds to 128 under both half-up and ties-to-even, so the tie test could not tell them apart (codex review on #1544). Add f1 = 195, where c = 110.5 codes: 111 half up, 110 ties-to-even. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
AdaWorldAPI
changed the title
This branch has not been deployed
2 participants
Being harvested for good — do not merge
This PR stays open only as a reminder of a landing zone. Its useful parts are to be harvested into code that fits the existing substrate. The PR is then closed, not merged.
Why not merge. W4 aimed at a lane-producing truth terminal in mask-risc plus
nal::Deduction-style types. That would be a second NARS truth substrate beside the one that already exists:CausalEdge64with its truth codes,causal_edge::isa::truth,syllogizeandrevision. NARS truth arithmetic has one home,isa::truth. Making that home exact is the conforming fix; a parallel per-row law inlance-graph-nalis not.What is harvested, and where it goes
tests/common/truth_law.rs: the exact integer law overu8codes, rounded once, half up, for deduction, analogy, induction and abductioncausal_edge::isa::truthexamples/w4_truth_law_probe.rs: an exhaustive sweep over all 2³² inputs per lawcausal-edgeagainstisa::truthf64on integer values is exact on every row of all four laws; the 256²u8table is off on 419M–775M rows;f32is off on 512–7,680 rowsisa::truthrework127.5 → 128and110.5 → 111(the second one rejects ties-to-even; codex review)causal-edgeunit testsnal1.1at4d1bdb0:%1.00;0.81%and%1.00;0.45%causal-edgetestsWhat is dropped
FoldDialecttruth methods.nal::Deduction-style types.nal-polyfill-v1.md§4 B/C that describe them.All of these would duplicate the CE64 substrate.
Open before the harvest
isa::truthbecomes exact (integer law,f64on integers, rounded once, half up). Right now it disagrees with the law by one code on some rows (12 rows on the every-5th-code grid for deduction).isa::truth.causal-edge.State of the branch (unchanged code)
causal-edgedev-dependency. No production code.fa6c572; a run ond18a664is pending.a_tie_rounds_upand the analogy test red;🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh