Skip to content

contract: R1 test checks every verdict from CognitiveWork - #1565

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-9f3b8075-74u47l-r1-test
Oct 15, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-9f3b8075-74u47l-r1-test

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Follow-up to #1560. The R1 test comment claimed that revision from CognitiveWork "is refused whatever the verdict". That stopped being true once #1560 made Necessary reachable: an accepted verdict (eligible and Necessary) advances CognitiveWork to Evaluation.

The behaviour is correct, and only the test was wrong. Moving on to Evaluation is not a goal revision. The goal is revised in the postactional phase, which is where this move lands.

The test now walks all nine (effect, counterfactual) verdicts from CognitiveWork and checks:

  • no verdict reopens the goal (Plan or Planning);
  • the one acceptable verdict moves on to Evaluation;
  • the other eight leave the column unchanged (None).

The silence twin (Evaluation → Plan → Planning) is unchanged.

Verification:

  • cargo test --lib kanban:: in lance-graph-contract: 18 passed.
  • Disable run: routing NoIncrease to Plan turns the test red.
  • clippy --profile test -D warnings is clean.

One question stays open: should an accepted verdict move CognitiveWork at all mid-action, or wait for the action to finish? This PR pins the current behaviour and leaves that to you.

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

The old comment said revision from CognitiveWork is refused whatever the
verdict. Since #1560 an accepted verdict (eligible and Necessary) is
reachable, and it advances CognitiveWork to Evaluation. The test now walks
all nine (effect, counterfactual) verdicts: none reopens the goal (Plan or
Planning), the one acceptable verdict moves on to Evaluation, the rest stay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9c5cfd8e-9a4d-4864-98ce-10cc8120cc3d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 15, 2026 21:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T21:19:03.405967Z 39ad8b1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 2379ddc into main Oct 15, 2026
15 checks passed
AdaWorldAPI pushed a commit that referenced this pull request Oct 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants