Repository navigation
D-WAL-6: wire the version clock into LanceCycleWriter - #1567
Conversation
…None) Clock equals storage at every version on a store the writer created; a reopened writer seeds at the head and answers None before it, as the VersionClock contract (#1562) says; deleted rows keep their positions; the reconciled append keeps the clock equal to storage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
The clock is seeded at the store's head on open (and on bootstrap) from the physical row counts in the held manifest, then recorded after every commit outcome. Deleted rows keep their positions; a version whose rows went back starts a new clock. No reads beyond the manifest the handle holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
VersionClock(#1562) had no writer.LanceCycleWriternow keeps one, following the clock's own contract.What changes
None.commit_cyclenow wraps the old body (moved unchanged tocommit_cycle_inner) and records the handle's version after every outcome:Committed,Reconciled, or an error after a reopen.Tests (red first, then green)
Nonebefore it; the next commit is recorded correctly.Disable runs, each red: no sync after commit (4 of 4 tests fail), counting live rows instead of positions (test 3 fails), starting a new clock on every sync (test 1 fails).
cargo test -p lance-graph --lib cycle_sinkpasses 28 of 28, andcargo clippy -p lance-graph --lib --tests -D warningsis clean.Open
🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code