Repository navigation
docs: rev-pin template, TD-POPCNT, AVX2 oracle note; OpenCog oracle and lance-graph-cog decisions - #1582
Conversation
…PCNT runtime-detect option, clarify baseline AVX2 arm CARGO-COMPUTE-SUBSTRATE and the cargo-substrate-architect card showed rev = "<pinned>" as the canonical coordinate; internal pins are forbidden, so the template now names branch = "master". TD-NDARRAY-SIMD-POPCNT-NATIVE item (b) proposed runtime detection inside kernels, which the startup-only cpu_guard rule excludes; its status line records the withdrawal. The .cargo/config.toml SIGILL note was correct and gains one line saying the AVX and x86-64-v2 arms apply only when requested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e via the ndarray polyfill is the goal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
… if validation earns it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…orting code is the risk Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…y source Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
… the fork is AGPL Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…k calls Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…indSpace DTO + quack Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…Node API and Rocks key map Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…h arc entries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
… KV, Rocks included Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bae6d9fca7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… scope on the board Codex review: native is for local and host-bound builds, shipped artifacts stay on x86-64-v4 / sapphirerapids. LATEST_STATE now names the OpenCog decisions and the ontology review item this PR also carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
The gather ban (#1590) excludes D2 and D-RA-4, sends D-ASM to a re-spec and promotes N19 (the join is the layout). New: bits 50..52 carry two opposite encodings in code (pyramid 7 -> 0, with_novelty_wisdom 1 -> 7); merged with D-MATURATION3-1. Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Docs and board only; nothing built. Two parts.
1. Doc fixes from the synergy map (#1579 §5, L3), lance-graph only
.claude/knowledge/CARGO-COMPUTE-SUBSTRATE.mdand.claude/agents/cargo-substrate-architect.mdshowedrev = "<pinned>"as the canonical ndarray coordinate. Internal pins are forbidden, so the template now namesbranch = "master".TECH_DEBT.mdTD-NDARRAY-SIMD-POPCNT-NATIVE: only the status line changes. Item (b), runtime feature detection inside kernels, is withdrawn: dispatch is compile time and the only CPU check is ndarray's startupcpu_guard. Items (a) and (c) stay open..cargo/config.toml: the SIGILL note stays. It now says that a build with no target-cpu takes ndarray's AVX2 arm only as the validation oracle; real builds go through the ndarray polyfill at a declared tier —nativefor local and host-bound builds, x86-64-v4 /sapphirerapidsfor shipped artifacts.2. OpenCog decisions (
entries/2026-10-16-opencog-oracle-scope.md)lance-graph-cogis the Apache-2.0 API an AGPL OpenCog fork would call; the fork (AdaWorldAPI/atomspace-lance) keeps only the thinStorageNodeadapter.lance-graph-ontologyis the precedent.TD-ONTOLOGY-REGISTRY-HASH-LOOKUP-REVIEW-1: review the ontology registry's string-keyed maps against codebook ids plus masks; not measured.Append-only files grow only (TECH_DEBT 4620 → 4632).
🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code