Skip to content

feat(simd): re-export AMX/VNNI int8 GEMM (matmul_i8_to_i32) through simd.rs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 1 commit into from
Jun 13, 2026
Merged

feat(simd): re-export AMX/VNNI int8 GEMM (matmul_i8_to_i32) through simd.rs #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/simd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,16 @@ pub use crate::hpc::cam_pq::{kmeans, squared_l2};

pub use crate::hpc::heel_f64x8::cosine_f32_to_f64_simd;

// Dispatched integer matmul — the polyfill entry for batched int8 scoring.
// `matmul_i8_to_i32` runtime-selects AMX `TDPBUSD` tiles (byte-asm, 16384
// MAC/instr, Sapphire Rapids+) → AVX-512 VPDPBUSD → AVX-VNNI → scalar, and
// is bit-identical across tiers. Surfaced here so a consumer reaches the
// whole AMX ladder through the canonical `ndarray::simd::*` import (W1a)
// without dipping into `crate::hpc::amx_matmul` directly. `amx_available()`
// exposes the runtime tier check for reporting.
#[cfg(feature = "std")]
pub use crate::hpc::amx_matmul::{amx_available, matmul_i8_to_i32};
Comment on lines +580 to +581

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate the AMX re-export on x86_64

On any std build for a non-x86_64 target, this import refers to crate::hpc::amx_matmul, but src/hpc/mod.rs only declares amx_matmul under #[cfg(target_arch = "x86_64")]. Since src/lib.rs still compiles pub mod simd for all std targets, default aarch64/wasm/s390x builds now fail with an unresolved import before consumers can use the crate. Please add the same target_arch = "x86_64" gate here or route to a portable wrapper.

Useful? React with 👍 / 👎.


// Elementwise slice ops — polyfill-dispatched (F32x16/F64x8 chunks + scalar tail).
#[cfg(feature = "std")]
pub use crate::simd_ops::{
Expand Down
Loading