Repository navigation
ci: run the nightly jobs on nightly; skip cpu_guard under Miri - #350
Conversation
…d under Miri The nightly-simd-polyfill, cargo-careful, docs/nightly and miri jobs run only on push / merge_group, so no PR showed them, and all four were red on master (already at 6704865): - nightly-simd-polyfill, docs, cargo-careful: dtolnay installs nightly, but rust-toolchain.toml pins stable and wins, so plain `cargo` was stable (E0554 on #![feature]; careful: target-spec-json "invalid JSON"). They now call `cargo +nightly`. - docs: `--all-features` cannot build (intel-mkl/openblas and runtime-dispatch/nightly-simd are mutually exclusive); it now uses the [package.metadata.docs.rs] set, approx,serde,rayon. - miri: cpu_guard's pre-main hook runs cpuid (inline asm), which Miri rejects, so every test binary died at --list. The hook is now cfg(not(miri)) on all three platforms, and the Miri filter skips cpu_guard:: tests. Verified locally with CI's RUSTFLAGS: the polyfill job reproduces E0554 on stable and passes with +nightly (both feature sets); the guard still fires on a normal build (v3 binary under qemu -cpu SandyBridge prints the guard message). The docs job now gets past the build and reports 127 rustdoc warnings (-Dwarnings) that it never reached before; one, a private link to DOT_I8_FOLD from #349, is fixed here, the other 126 predate this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (47)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
…ings
The docs job never reached rustdoc before (it failed at the build), so these
had accumulated unseen. Doc-comment lines only; no code changes.
- 104 index expressions in prose (`a[i]`, `[768]`, `self[k]`) parsed as
intra-doc links: brackets escaped (`\[i\]`, renders identically).
Fenced code blocks are left untouched.
- 7 chained forms (`basis_cos[f][j]`, byte layouts like
`[name_len:u32][name]...`): put in code spans.
- 9 links to private items: kept as code spans without the link.
- 7 unclosed HTML tags (`Vec<u8>`, `LazyLock<Tier>`): put in code spans.
- Paths fixed: crate::hpc::quantized::int8_gemm_i32, the soa_struct! and
blocked_grid_struct! macros (crate::), BlockedGrid::{new, new_with_pad,
idx}, blas_rotg; jitson_cranelift (feature jit-native) is now unlinked;
one redundant link target simplified.
Verified: RUSTDOCFLAGS="-Dwarnings --cfg docsrs" cargo +nightly doc --no-deps
--features approx,serde,rayon exits 0 (was 127 warnings); every changed line
is a /// or //! line; clippy v3 and fmt clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Local results for the two nightly jobs this PR's own CI cannot show (both run only on
Generated by Claude Code |
careful rebuilds std from source and needs rust-src; without it a local run stalled for 25 minutes with no compiler process. With it, the cpu_guard smoke run passes (8/8). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Four CI jobs had been red on
mastersince at least6704865:nightly-simd-polyfill,cargo-careful,docs/nightlyandmiri. They run only onpush/merge_group, so no PR ever showed them. Three of them were never running on nightly at all.Causes and fixes
nightly-simd-polyfilldtolnay/rust-toolchain@nightlyinstalls nightly, butrust-toolchain.tomlpins stable and takes precedence, so plaincargois stable →E0554: #[feature] may not be used on the stable release channelcargo +nightly checkcargo-carefulrustc --print target-spec-json("output is invalid JSON")cargo +nightly carefuldocs/nightly--all-featurescannot build at all:intel-mkl/openblasandruntime-dispatch/nightly-simdare mutually exclusive (compile_error!)cargo +nightly doc --features approx,serde,rayon, the[package.metadata.docs.rs]setmiricpu_guard's pre-mainhook (from #348) runscpuid, which is inline assembly, and Miri rejects that, so every test binary aborted at--listcfg(not(miri))on all three platforms; the Miri filter skipscpu_guard::testsVerified locally (with CI's
RUSTFLAGS)E0554on stable; both+nightlyfeature sets pass.qemu -cpu SandyBridgeprints the guard's message instead of hitting SIGILL.cpu_guardtests 8/8; clippy-D warningsclean on v3 and avx; fmt clean.target-spec-json"invalid JSON") reproduces locally. The+nightlyrun and the Miri smoke run: results in a follow-up comment.The docs job's 126 pre-existing warnings: fixed (
a1b8055)With the build fixed,
docs/nightlyreached rustdoc for the first time and-Dwarningsreported 127 warnings. This PR fixes all of them. Only//////!lines change (122 lines, 43 files); there are no code changes:104 index expressions in prose (
a[i],[768],self[k]) were parsed as intra-doc links. Their brackets are now escaped, which renders identically; fenced code blocks are untouched.7 chained formulas or byte layouts (
basis_cos[f][j],[name_len:u32][name]…), and 7 bare generics (Vec<u8>,LazyLock<Tier>) that rustdoc read as unclosed HTML tags, now sit in code spans.9 links to private items keep their code formatting but are no longer links.
Paths corrected:
crate::hpc::quantized::int8_gemm_i32;soa_struct!andblocked_grid_struct!macros;BlockedGrid::{new, new_with_pad, idx};blas_rotg.jitson_cranelift(featurejit-native) is no longer a link, and one redundant link target is simplified.Verified:
RUSTDOCFLAGS="-Dwarnings --cfg docsrs" cargo +nightly doc --no-deps --features approx,serde,rayonexits 0. Clippy v3 and fmt are clean.Note on verification
These four jobs run only on
push/merge_group, so this PR's own CI cannot show them; the evidence is the local runs above. They will run for real on the merge tomaster.🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code