Repository navigation
splat3d_correctness: clippy 1.99 clean under --features splat3d - #351
Merged
Merged
Conversation
Five lints in the test file: needless mut on a closure, an over-precise f32 literal (same bits, 0x3e906ebb), three chunks_exact(3) -> as_chunks. No behaviour change; 5/5 pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 09:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes five clippy 1.99 lints in
tests/splat3d_correctness.rs. All are in the test file:muton a closure;0.28209479177387814becomes0.282_094_8, with identical bits (0x3e906ebb);chunks_exact(3)calls replaced byas_chunks::<3>().0.iter().The file is
#[cfg(feature = "splat3d")], so these lints only appear with the feature on. A plaincargo clippy --test splat3d_correctnesscompiles nothing and reports success.Verification:
cargo clippy --features splat3d --test splat3d_correctness -- -D warningsis clean.cargo test --features splat3d --test splat3d_correctnesspasses 5/5.There is no behaviour change. A blackboard entry is included.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Generated by Claude Code