Skip to content

splat3d_correctness: clippy 1.99 clean under --features splat3d - #351

Merged
AdaWorldAPI merged 1 commit into
masterfrom
ccr-b2e415d9-4jfvyk
Oct 10, 2026
Merged

AdaWorldAPI merged 1 commit into
masterfrom
ccr-b2e415d9-4jfvyk

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Fixes five clippy 1.99 lints in tests/splat3d_correctness.rs. All are in the test file:

  • an unneeded mut on a closure;
  • an over-precise f32 literal: 0.28209479177387814 becomes 0.282_094_8, with identical bits (0x3e906ebb);
  • three chunks_exact(3) calls replaced by as_chunks::<3>().0.iter().

The file is #[cfg(feature = "splat3d")], so these lints only appear with the feature on. A plain cargo clippy --test splat3d_correctness compiles nothing and reports success.

Verification:

  • cargo clippy --features splat3d --test splat3d_correctness -- -D warnings is clean.
  • cargo test --features splat3d --test splat3d_correctness passes 5/5.

There is no behaviour change. A blackboard entry is included.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R


Generated by Claude Code

Five lints in the test file: needless mut on a closure, an over-precise
f32 literal (same bits, 0x3e906ebb), three chunks_exact(3) -> as_chunks.
No behaviour change; 5/5 pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 7ff00f14-f907-4a33-af08-ed784b84b776

📥 Commits

Reviewing files that changed from the base of the PR and between 9402e57 and 9a63e7a.


📒 Files selected for processing (2)
  • .claude/blackboard.md
  • tests/splat3d_correctness.rs

 ______________________________________________________________________________________________________
< Fools ignore complexity. Pragmatists suffer it. Some can avoid it. Geniuses remove it. - Alan Perlis >
 ------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 09:43
@AdaWorldAPI
AdaWorldAPI merged commit 59bdb04 into master Oct 10, 2026
18 of 19 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T09:45:06.159570Z 9a63e7a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants