Repository navigation
simd: withdraw mask_gather_chain_u32 (rejected design) - #359
Merged
Merged
Conversation
…up branch) The chained gather treated a hop as a key read: every anchor row walked every hop, each address being the previous read's value. The graph has no foreign keys; a hop is a coordinate range, and chained hops are the intersection of ranges. lance-graph D-TELEPORT-0 (#1484) had measured the gather shape as accelerating, not eliminating, work before #358. Removes the two functions, ChainHop, ChainTest, their tests and the parity case. Exact prior state: backup/session-011BMJ-2026-10-12. Blackboard entry records the reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the chained gather that #358 added:
mask_gather_chain_u32,mask_gather_chain_u32_under,ChainHopandChainTest, together with their tests and the parity case 0xD02/0xD03.The design was wrong, not just slow:
The code before this change is kept on
backup/session-011BMJ-2026-10-12. The reason is recorded in.claude/blackboard.md.This PR adds no replacement. The rebuild reuses lance-graph's mask-risc/Quack folds, and a new primitive lands here only if that rebuild measures a gap.
Test plan
cargo clippy --all-targets -- -D warnings, AVX-512 tier,env -u RUSTFLAGScargo fmt --checkcargo test --lib simd_masking_ops: 169 passedsimd-masking-parity: clippy clean; run reports 16 groups bit-identicalsrc,crates,scripts,.githubordocs🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code