Skip to content

simd: withdraw mask_gather_chain_u32 (rejected design) - #359

Merged
AdaWorldAPI merged 1 commit into
masterfrom
ccr-9f3b8075-74u47l-chain-reject
Oct 12, 2026
Merged

AdaWorldAPI merged 1 commit into
masterfrom
ccr-9f3b8075-74u47l-chain-reject

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Summary

This PR removes the chained gather that #358 added: mask_gather_chain_u32, mask_gather_chain_u32_under, ChainHop and ChainTest, together with their tests and the parity case 0xD02/0xD03.

The design was wrong, not just slow:

  • It treats a hop as a key read. Each anchor row walks every hop, and the address of each read is the value the previous read returned.
  • The graph has no foreign keys. Everything is Cartesian coordinates: a hop is a coordinate range on the sealed, ordered address, and a chain of hops is the intersection of those ranges.
  • lance-graph D-TELEPORT-0 (#1484) had already measured the gather shape before simd: chained gather — a chain of key reads folded into one pass #358 was written: it speeds up the work but does not eliminate it.

The code before this change is kept on backup/session-011BMJ-2026-10-12. The reason is recorded in .claude/blackboard.md.

This PR adds no replacement. The rebuild reuses lance-graph's mask-risc/Quack folds, and a new primitive lands here only if that rebuild measures a gap.

Test plan

  • cargo clippy --all-targets -- -D warnings, AVX-512 tier, env -u RUSTFLAGS
  • cargo fmt --check
  • cargo test --lib simd_masking_ops: 169 passed
  • simd-masking-parity: clippy clean; run reports 16 groups bit-identical
  • No other reference to the removed names in src, crates, scripts, .github or docs

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

…up branch)

The chained gather treated a hop as a key read: every anchor row walked
every hop, each address being the previous read's value. The graph has
no foreign keys; a hop is a coordinate range, and chained hops are the
intersection of ranges. lance-graph D-TELEPORT-0 (#1484) had measured
the gather shape as accelerating, not eliminating, work before #358.

Removes the two functions, ChainHop, ChainTest, their tests and the
parity case. Exact prior state: backup/session-011BMJ-2026-10-12.
Blackboard entry records the reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f339ccda-b3f9-4647-be13-445843f11be5
📥 Commits

Reviewing files that changed from the base of the PR and between e726f98 and 56c4669.

📒 Files selected for processing (4)
  • .claude/blackboard.md
  • crates/simd-masking-parity/src/lib.rs
  • src/simd.rs
  • src/simd_masking_ops.rs
 ____________________________________________________________
< To infinity and beyond! Scouring your code for pesky bugs. >
 ------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 12, 2026 22:20
@AdaWorldAPI
AdaWorldAPI merged commit 3f404c5 into master Oct 12, 2026
29 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T22:21:45.528656Z 56c4669 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants