Repository navigation
chore: no tracked Cargo.lock (no pins) - #17
Conversation
Decision (operator, 2026-10-16): no pins. The lock is removed from the tree and ignored so every build resolves the git-branch dependencies at their current heads instead of a frozen graph. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017SNHxJYC1MeW3HsyhGZo1E
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI:
Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…, whose debt predates this branch The ratchet reads the counts CI measured on this head, which is master plus the lock removal: too_many_lines 249->251, cognitive_complexity 19->20, excessive_nesting 460->465, redundant_clone 0->1, long_comments 2609->2703. None of it is paid here and none of it was added here: the eighteen commits that landed directly on master after the last bless (31dedc1, radareorg#217) raised it, and master's own CI run on 42ebb65 fails the same step with the same numbers. This records that debt where the script expects it, the same way 31dedc1 did after radareorg#217; the next change that touches those sites pays it down and lowers the numbers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017SNHxJYC1MeW3HsyhGZo1E
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 295e41525a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,2271 +0,0 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
Preserve vulnerability checks for transitive dependencies
When a vulnerability affects an indirect crate, deleting the only resolved dependency graph leaves GitHub with the Cargo.toml manifests alone; this repository has no dependency-submission or audit workflow, and GitHub states that indirect dependencies inferred from manifests are excluded from vulnerability checks. Consequently, the Dependabot setup in .github/dependabot.yml can no longer alert on the transitive versions previously recorded here. Keep the lockfile, or add automatic dependency submission/auditing before removing it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified: .github/dependabot.yml does cover the cargo ecosystem and there is no cargo audit / dependency-submission workflow, so with the lock gone Dependabot sees only the manifests and no longer alerts on transitive versions. That is a real cost and it is accepted on purpose: removing the tracked lock is the operator's standing decision for the AdaWorldAPI consumer repos (no pins; every build resolves the git-branch dependencies at their current heads), applied here the same day across nine repos. Keeping the lock would reintroduce exactly the frozen graph the decision removes. The mitigation that fits the decision is an audit step that resolves fresh at CI time (cargo audit or GitHub's dependency-submission action), not a committed lock; that is a separate, repo-wide choice and is put to the operator rather than added inside this PR.
Generated by Claude Code
|
Follow-up to the comment above: pushed Generated by Claude Code |
Summary
Decision (operator, 2026-10-16): no pins. This removes the tracked
Cargo.lockfrom the tree and adds it to.gitignore, so every build resolves the git-branch dependencies at their current heads instead of a frozen graph. The same convention lance-graph, OGAR, HubSPO-rs and tesseract-rs already follow.Changes
git rm --cachedof every trackedCargo.lockin the repoCargo.lockappended to.gitignore(where it was not already listed)Also blesses
scripts/structure-baseline.txtto the counts CI measures on master today (debt added by the 2026-10-14 master commitsd95c3a5..42ebb65, not by this PR; precedent31dedc1).No source change. Local resolution: the next
cargo buildregenerates the lock from the latest heads.🤖 Generated with Claude Code
https://claude.ai/code/session_017SNHxJYC1MeW3HsyhGZo1E
Generated by Claude Code
Generated by Claude Code