Repository navigation
feat: automatic contextual memory across conversations and task workers - #1892
Merged
Merged
Conversation
santoshkumarradha
marked this pull request as draft
October 22, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Ordinary conversation captures durable memories and applies them in later chats without a remember command. Natural corrections update remembered decisions; explicit pins remain available.
V2 uses proof-only reinforcement and negative contradiction feedback, a protected durable admission lane with a 40% floor, specificity ranking, derived semantic labels, conversation dwell, and actual-prompt telemetry. ACT-R activation, threshold admission, unrestricted storage, conservative SimHash deduplication, pins, and the performance budget remain intact.
Capture guidance now distinguishes statements and accepted proposals from unaccepted assistant suggestions. A contradictory worked example was corrected. Normalized wording and natural confirmations still work. Explicit media pins cannot silently fall back under one-model mode.
Proof
The latest candidate is a278210. Its production change is 3b4da43; the subsequent commit adds the live regression.
deepseek/deepseek-v4.1-flash, including auxiliary roles.make pr-readypasses, including build, vet, manual gates, repository laws, fixed-prefix budget and fresh tests for all seven affected packages. Latest-revision GitHub CI passes: all eight jobs green on a278210. The manual-search failure on the previous CI merge was reproduced and fixed without a waiver; its packed-manual tests pass.The live regression used fictional Cedar rainfall instructions. The assistant proposed an orientation as an example; capture excluded it. A later correction changed overflow delivery from a link to an SVG attachment. The actual task wrote:
{ "fits_in_chat": { "delivery": "Render the full chart inline in the chat reply.", "inline_allowed": true }, "does_not_fit_in_chat": { "delivery": "Do not render inline; save the full chart as an SVG attachment.", "inline_allowed": false } }Earlier runs exposed to grading material or using a different media model were excluded. Personal memory examples, prompts, and transcripts are not published.
Acceptance policy and limitations
Actual recall and correct application take priority. The legacy use-count calibration remains a diagnostic regression signal, not a release blocker: current settings yield 15/23 and 28.6% unused share. Seven offline refits restored 23/23 and 0% unused share but dropped one or two actual recall targets. The current settings preserve all 13 targets.
The first complex attempt was excluded after its evaluator deadline interrupted a still-running task. The successful run used an eight-minute per-turn limit and stopped on missing replies. The queued-worker observer initially expected the wrong receipt tag; retained task records, linked worker requests and artifact checks independently establish its success. This was an evaluator classification error, not a product fix.
Capture remains model-guided, not a lossless guarantee. Conservative lexical deduplication does not merge every semantic paraphrase; two similar old captures existed in the new regression before correction removed both from the active set. Embeddings and automatic state-summary consolidation are not included.
Aggregate proof is included inline. Direct media attachment upload is unavailable through the current tools; recordings and detailed evidence are preserved locally. No evidence directories or branches were committed.
Reproduce the mock regression
After
make build, with credentials configured privately:The isolated live harness requires Linux, tmux, and bubblewrap. The manual and change entry document behavior and limitations.