[fix] Show effective integration permissions - #6385
Conversation
|
@Aman-goel-04 is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change resolves inherited integration permissions for display, passes agent policy data into tool group rollups, and adds tests for effective permissions and group labels. ChangesIntegration permission display
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This update makes inherited integration permissions display their effective read and write/delete behavior without changing enforcement or saved permissions. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes resolve inherited permissions against the agent policy and display read-only tools as "runs automatically" and write/delete tools as "asks first," matching issue ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The integration permission drawer showed
Follow agent policyfor both read-only and write/delete tools when the integration used theAsk for write and deletepreset.The root cause was that the drawer displayed the stored
inheritvalue without resolving it against the agent-level permission policy. The runner already resolves this correctly, but the drawer did not show the effective result.The drawer now resolves inherited permissions for display:
allow_readsasruns automatically.allow_readsasasks first.Fixes #6346
Testing
Verified locally
pnpm --filter @agenta/entity-ui lint.pnpm --filter @agenta/entity-ui build.Ask for write and delete.runs automaticallyasks firstAdded or updated tests
Added unit coverage for:
allow_reads.The focused test suite passes: 20 tests.
QA follow-up
N/A
Demo
Attach screenshots or videos captured from the real app running this branch:
follows agent policy.runs automatically, and write and delete showsasks first.Checklist