Repository navigation
[O2B-1633] Fix shadow of tables with scroll not being displayed - #2257
Merged
graduta merged 1 commit intoOct 20, 2026
Merged
Conversation
…displayed Tables displayed with horizontal and/or vertical scroll (for example on the runs per data pass and runs per simulation pass pages) are wrapped in `overflow: auto` containers, which clip the table box-shadow. Add a `table-shadow-room` class to the first wrapper of scrollable tables, leaving 6px on the sides and at the bottom (not at the top, to keep the sticky header in place) so that the shadow is visible. Add UI tests on the runs per data pass and runs per simulation pass pages.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
- Coverage 46.47% 46.46% -0.01%
==========================================
Files 1052 1052
Lines 17357 17358 +1
Branches 3163 3164 +1
==========================================
Hits 8066 8066
- Misses 9291 9292 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
No open issues 🎉
What changed in this PR
Fixes clipped shadows on scrollable tables by adding spacing around their wrappers and covering affected pages with UI tests.
Changes:
- Adds
table-shadow-roomto scroll-enabled table wrappers. - Adds padding to preserve table shadows.
- Adds UI coverage for data-pass and simulation-pass tables.
| File | Description |
|---|---|
test/public/runsPerPeriodOrPass/runsPerSimulationPass.overview.test.js |
Tests simulation-pass table shadow spacing. |
test/public/runsPerPeriodOrPass/runsPerDataPass.overview.test.js |
Tests data-pass table shadow spacing. |
lib/public/components/common/table/table.js |
Applies the shadow-room wrapper class. |
lib/public/app.css |
Defines wrapper padding for shadow visibility. |
Review effort: Lite
graduta
deleted the
bug/O2B-1633/shadow-not-displayed-on-table-with-scroll
branch
October 20, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
tablecomponent adds atable-shadow-roomclass to the first wrapper of tables with scroll enabled, which adds padding (left, right and bottom, not top to keep the sticky header in place) so the table shadow is not clipped.Changes made to the database: