Repository navigation
Conversation
…o DONE Add a migration converting DESTROYED history items to DONE and update the seeders accordingly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
DONE is now the only terminal status: drop DESTROYED from the status enums, DTO validation, colours and SQL queries, and simplify the status history filter of GetAllEnvironmentsUseCase now that 'X' maps to a single status. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…status Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Closing: superseded by a PR from the correctly named branch (O2B-1515). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
- Coverage 46.49% 46.44% -0.05%
==========================================
Files 1051 1053 +2
Lines 17341 17352 +11
Branches 3156 3160 +4
==========================================
- Hits 8062 8060 -2
- Misses 9279 9292 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
explain what this PR does
The
DESTROYEDenvironment status is deprecated in favour ofDONE. This PR migrates existing data and removes every usage ofDESTROYEDin the code, seeders and tests.if it is a new feature, explain how you plan to use it
tests are added (existing tests/seeders updated to use
DONE)documentation was updated or added
Notable changes for users:
DESTROYEDstatus are now shown asDONE;DESTROYEDis no longer available in the status filterNotable changes for developers:
DESTROYEDremoved from status enums (server and public), history item DTO validation, status colours and raw SQL queriesGetAllEnvironmentsUseCase: status history filter simplified, a trailingXnow only anchors the match to the end of the history (singleDONEstatus)transitionToErrorLostEnvironmentsnow also excludes environments alreadyDONEAliEcsSynchronizerforwards the AliECS state as is, so an incomingDESTROYEDstate would now be rejected by validationChanges made to the database:
20261019110000-environment-destroyed-status-to-done:UPDATE environments_history_items SET status = 'DONE' WHERE status = 'DESTROYED'(downis a no-op as the conversion cannot be reverted)