Replace the flag-forwarding grep heuristic with an explicit table

This fixes run_tests.sh forwarding flags to sub-test scripts by
grepping their source instead of knowing which flags each one accepts.

- The grep matched a flag string in a comment as readily as in real
  argument parsing, and never matched at all against the selection
  harness's stub scripts, so the forwarding logic was untested.
- Only run_generator_tests.sh accepts --fail-immediately and
  --keep-artifacts; run_workflow_tests.sh and run_relval_tests.sh only
  accept --help/-h. Forwarding is now a plain case on the sub-test name.
- Extended the stub scripts in the selection harness to record their
  received arguments, and added a case asserting --keep-artifacts
  reaches the generator stub and not the workflow or relval stubs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: sawenzel

test/run_tests.sh

@@ -68,11 +68,12 @@ for subtest in "${selected[@]}" ; do
     fi
     echo
     echo "==> START SUBTEST: ${subtest} <=="
-    forward=()
-    for arg in "${subtest_args[@]:-}" ; do
-        [[ -z "${arg}" ]] && continue
-        grep -q -- "${arg}" "${script}" && forward+=("${arg}")
-    done
+    # Only run_generator_tests.sh accepts --fail-immediately/--keep-artifacts;
+    # run_workflow_tests.sh and run_relval_tests.sh accept only --help/-h.
+    case ${subtest} in
+        generator ) forward=("${subtest_args[@]:-}") ;;
+        * )         forward=() ;;
+    esac
     "${script}" "${forward[@]}"
     ret_this=$?
     echo "==> END SUBTEST: ${subtest} (exit ${ret_this}) <=="

test/tests/run_tests_selection.sh

@@ -18,7 +18,9 @@ check()
     fi
 }
 
-# A stub directory with three scripts whose exit codes we control via env vars.
+# A stub directory with three scripts whose exit codes we control via env
+# vars, and which each record the arguments they received to a sibling
+# "*.args" file (one per line) so forwarding can be checked.
 make_stubs()
 {
     local dir=$1
@@ -27,6 +29,7 @@ make_stubs()
         cat > "${dir}/run_${name}_tests.sh" <<EOF
 #!/bin/bash
 echo "STUB ${name} ran"
+printf '%s\n' "\$@" > '${dir}/run_${name}_tests.args'
 exit \${STUB_${name^^}_RC:-0}
 EOF
         chmod +x "${dir}/run_${name}_tests.sh"
@@ -73,6 +76,15 @@ check "fail-immediately stops early" 0 "$(grep -c 'STUB relval ran' <<< "${OUT}"
 STUB_RELVAL_RC=4 run_entry "${TMP}/subtests"
 check "late failure propagates" 4 "${RC}"
 
+# 6. flag forwarding is per sub-test: only "generator" accepts these flags
+run_entry "${TMP}/subtests" --keep-artifacts
+check "keep-artifacts reaches generator" \
+      1 "$(grep -cx -- '--keep-artifacts' "${TMP}/subtests/run_generator_tests.args")"
+check "keep-artifacts does not reach workflow" \
+      0 "$(grep -cx -- '--keep-artifacts' "${TMP}/subtests/run_workflow_tests.args")"
+check "keep-artifacts does not reach relval" \
+      0 "$(grep -cx -- '--keep-artifacts' "${TMP}/subtests/run_relval_tests.args")"
+
 echo
 if [[ "${FAILURES}" == "0" ]] ; then
     echo "All run_tests.sh selection tests passed"