Run the O2DPG simulation tests against a CVMFS release instead of building O2sim - #2470
Merged
Merged
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
force-pushed
the
cvmfs-sim-tests
branch
from
September 21, 2026 20:18
ebaeed5 to
bb89a75
Compare
This replaces the aliBuild-based simulation-test check with a GitHub Actions job that runs the existing tests against a published O2PDPSuite release, and fixes two exit-code problems in the workflow tests. - test/run_tests.sh now owns the environment setup, sub-test selection and exit-code aggregation that lived in the alidist recipe body. - The new job runs on a self-hosted runner with CVMFS and compiles nothing. - run_workflow_tests.sh dropped ret_global_pwg from its final exit code, so a failed PWG workflow creation reported FAILED and still passed. - The AnalysisQC execution block was gated differently from the announcement above it; both now agree. - Three offline harnesses under test/tests/ check the entrypoint, the tag selection and the exit-code aggregation, and syntax-checks.yml runs them. - Touching test/needs-o2-dev opts a pull request into a source build against O2 dev, for changes that cannot use a published release. - curl's include directory is added to ROOT_INCLUDE_PATH, derived from curl-config, because O2's CCDB dictionary payload includes curl/curl.h and a runtime environment carries no curl headers. - The alidist recipe and the ali-bot check are left in place for now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sawenzel
force-pushed
the
cvmfs-sim-tests
branch
from
September 21, 2026 20:43
bb89a75 to
63a0b99
Compare
sawenzel
marked this pull request as ready for review
September 22, 2026 06:10
sawenzel
requested review from
chiarazampolli,
davidrohr,
jackal1-66 and
shahor02
as code owners
September 22, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
build/O2DPG/sim/o2aliBuild check with a GitHub Actions job that runs the existing tests against a publishedO2PDPSuiterelease from CVMFS. Nothing is compiled, so an unrelated recipe failure elsewhere in the stack can no longer fail an O2DPG pull request.Also fixes two exit-code bugs in
test/run_workflow_tests.sh:ret_global_pwgnever reached the final exit code, and the AnalysisQC execution block was gated differently from the announcement above it.The alidist recipe and the ali-bot check stay in place until this has run green beside them.
Draft: open to exercise the new job on real CI.