Skip to content

[Common] fix linter warnings, add further QA #16264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddobrigk merged 3 commits into from
May 15, 2026
+105 −24
Merged

[Common] fix linter warnings, add further QA #16264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c83c0
[Common] fix linter warnings, add further QA
ddobrigk May 15, 2026
9e99c9f
Please consider the following formatting changes (#508)
alibuild May 15, 2026
33da2c7
linter fix
ddobrigk May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 105 additions & 24 deletions Common/Tasks/centralityStudypp.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in Common/Tasks/centralityStudypp.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -14,11 +14,9 @@
// multCentTable output

#include "Common/CCDB/EventSelectionParams.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/Multiplicity.h"

#include <CCDB/BasicCCDBManager.h>
#include <DataFormatsParameters/GRPECSObject.h>
#include <Framework/AnalysisDataModel.h>
#include <Framework/AnalysisHelpers.h>
#include <Framework/AnalysisTask.h>
Expand All @@ -34,7 +32,6 @@
#include <TList.h>
#include <TProfile.h>

#include <bitset>
#include <cstdint>
#include <format>
#include <map>
Expand All @@ -53,26 +50,36 @@
std::map<std::string, HistPtr> histPointers;
std::string histPath;
Service<o2::ccdb::BasicCCDBManager> ccdb;
int mRunNumber;
uint64_t startOfRunTimestamp;
int mRunNumber = -1;

// vertex Z equalization
TList* hCalibObjects;
TProfile* hVtxZFV0A;
TProfile* hVtxZFT0A;
TProfile* hVtxZFT0C;
TProfile* hVtxZNTracks;
TProfile* hVtxZNGlobals;
TProfile* hVtxZMFT;
TProfile* hVtxZFDDA;
TProfile* hVtxZFDDC;
TList* hCalibObjects = nullptr;
TProfile* hVtxZFV0A = nullptr;
TProfile* hVtxZFT0A = nullptr;
TProfile* hVtxZFT0C = nullptr;
TProfile* hVtxZNTracks = nullptr;
TProfile* hVtxZNGlobals = nullptr;
TProfile* hVtxZMFT = nullptr;
TProfile* hVtxZFDDA = nullptr;
TProfile* hVtxZFDDC = nullptr;

// calibration histograms
TH1* hCentralityFV0A = nullptr;
TH1* hCentralityFT0A = nullptr;
TH1* hCentralityFT0C = nullptr;
TH1* hCentralityFT0M = nullptr;
TH1* hCentralityFDDM = nullptr;
TH1* hCentralityNTPV = nullptr;
TH1* hCentralityNGlo = nullptr;
TH1* hCentralityMFT = nullptr;

// Configurables
Configurable<bool> do2DPlots{"do2DPlots", true, "0 - no, 1 - yes"};
// _______________________________________
// event selection criteria
Configurable<bool> applyVertexZEqualization{"applyVertexZEqualization", false, "0 - no, 1 - yes"};
Configurable<bool> saveUnequalized{"saveUnequalized", false, "save unequalized raw: 0 - no, 1 - yes"};
Configurable<bool> doCentralityQA{"doCentralityQA", false, "do centrality QA: 0 - no, 1 - yes"};
Configurable<bool> applySel8{"applySel8", true, "0 - no, 1 - yes"};
Configurable<bool> applyVtxZ{"applyVtxZ", true, "0 - no, 1 - yes"};
Configurable<bool> requireINELgtZERO{"requireINELgtZERO", true, "0 no, 1 - yes"};
Expand All @@ -84,6 +91,8 @@
Configurable<bool> requireIsVertexTRDmatched{"requireIsVertexTRDmatched", false, "require events with at least one of vertex contributors matched to TRD"};
Configurable<bool> rejectSameBunchPileup{"rejectSameBunchPileup", false, "reject collisions in case of pileup with another collision in the same foundBC"};

Configurable<float> vertexZcut{"vertexZcut", 10.0f, "vertex Z cut (cm)"};

// For one-dimensional plots, where binning is no issue
ConfigurableAxis axisMultUltraFineFV0A{"axisMultUltraFineFV0A", {60000, 0, 60000}, "FV0A amplitude"};
ConfigurableAxis axisMultUltraFineFT0A{"axisMultUltraFineFT0A", {60000, 0, 60000}, "FT0A amplitude"};
Expand All @@ -97,11 +106,14 @@
// For profile Z
ConfigurableAxis axisPVz{"axisPVz", {400, -20.0f, +20.0f}, "PVz (cm)"};
ConfigurableAxis axisZN{"axisZN", {1100, -50.0f, +500.0f}, "ZN"};
// For centrality QA
ConfigurableAxis axisCentrality{"axisCentrality", {10000, 0, 100}, "centrality percentile"};

// ccdb matters
Configurable<std::string> ccdbURL{"ccdbURL", "http://alice-ccdb.cern.ch", "ccdb url"};
Configurable<std::string> pathGRPECSObject{"pathGRPECSObject", "GLO/Config/GRPECS", "Path to GRPECS object"};
Configurable<std::string> pathVertexZ{"pathVertexZ", "Users/d/ddobrigk/Centrality/Calibration", "Path to vertexZ profiles"};
Configurable<std::string> pathCentrality{"pathCentrality", "Users/d/ddobrigk/Centrality/Estimators", "Path to centrality calibration"};

void init(InitContext&)
{
Expand All @@ -115,6 +127,15 @@
hVtxZFDDA = nullptr;
hVtxZFDDC = nullptr;

hCentralityFV0A = nullptr;
hCentralityFT0A = nullptr;
hCentralityFT0C = nullptr;
hCentralityFT0M = nullptr;
hCentralityFDDM = nullptr;
hCentralityNTPV = nullptr;
hCentralityNGlo = nullptr;
hCentralityMFT = nullptr;

const AxisSpec axisCollisions{100, -0.5f, 99.5f, "Number of collisions"};
histos.add("hCollisionSelection", "hCollisionSelection", kTH1D, {{20, -0.5f, +19.5f}});
histos.get<TH1>(HIST("hCollisionSelection"))->GetXaxis()->SetBinLabel(1, "All collisions");
Expand Down Expand Up @@ -171,21 +192,39 @@
LOGF(info, "Acquiring vertex-Z profiles for run %i", mRunNumber);
hCalibObjects = ccdb->getForRun<TList>(pathVertexZ, mRunNumber);

hVtxZFV0A = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFV0A"));
hVtxZFT0A = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFT0A"));
hVtxZFT0C = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFT0C"));
hVtxZFDDA = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFDDA"));
hVtxZFDDC = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFDDC"));
hVtxZNTracks = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZNTracksPV"));
hVtxZNGlobals = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZNGlobals"));
hVtxZMFT = static_cast<TProfile*>(hCalibObjects->FindObject("hVtxZMFT"));
hVtxZFV0A = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFV0A"));
hVtxZFT0A = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFT0A"));
hVtxZFT0C = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFT0C"));
hVtxZFDDA = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFDDA"));
hVtxZFDDC = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZFDDC"));
hVtxZNTracks = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZNTracksPV"));
hVtxZNGlobals = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZNGlobals"));
hVtxZMFT = dynamic_cast<TProfile*>(hCalibObjects->FindObject("hVtxZMFT"));

// Capture error
if (!hVtxZFV0A || !hVtxZFT0A || !hVtxZFT0C || !hVtxZFDDA || !hVtxZFDDC || !hVtxZNTracks || !hVtxZNGlobals || !hVtxZMFT) {
LOGF(error, "Problem loading CCDB objects! Please check");
}
}

if (doCentralityQA.value) {
// acquire vertex-Z equalization histograms if requested
LOGF(info, "Acquiring vertex-Z profiles for run %i", mRunNumber);
TList* hCentralityObjects = nullptr;
hCentralityObjects = ccdb->getForRun<TList>(pathCentrality, mRunNumber);

hCentralityFV0A = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqFV0"));
hCentralityFT0A = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqFT0A"));
hCentralityFT0C = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqFT0C"));
hCentralityFT0M = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqFT0"));
hCentralityFDDM = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqFDD"));
hCentralityNTPV = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqNTracksPV"));
hCentralityNGlo = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqNGlobal"));
hCentralityMFT = dynamic_cast<TProfile*>(hCentralityObjects->FindObject("hCalibZeqMFT"));

// won't capture null pointers -> explicitly check for those when attempting to evaluate
}

histPath = std::format("Run_{}/", mRunNumber);

histPointers.insert({histPath + "hCollisionSelection", histos.add((histPath + "hCollisionSelection").c_str(), "hCollisionSelection", {kTH1D, {{20, -0.5f, +19.5f}}})});
Expand Down Expand Up @@ -227,6 +266,17 @@
histPointers.insert({histPath + "hNPVContributors_Unequalized", histos.add((histPath + "hNPVContributors_Unequalized").c_str(), "hNPVContributors_Unequalized", {kTH1D, {{axisMultUltraFinePVContributors}}})});
}

if (doCentralityQA.value) {
histPointers.insert({histPath + "hCentralityDistributionFV0A", histos.add((histPath + "hCentralityDistributionFV0A").c_str(), "hCentralityDistributionFV0A", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionFT0A", histos.add((histPath + "hCentralityDistributionFT0A").c_str(), "hCentralityDistributionFT0A", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionFT0C", histos.add((histPath + "hCentralityDistributionFT0C").c_str(), "hCentralityDistributionFT0C", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionFT0M", histos.add((histPath + "hCentralityDistributionFT0M").c_str(), "hCentralityDistributionFT0M", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionFDDM", histos.add((histPath + "hCentralityDistributionFDDM").c_str(), "hCentralityDistributionFDDM", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionNPTV", histos.add((histPath + "hCentralityDistributionNPTV").c_str(), "hCentralityDistributionNPTV", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionNGlobal", histos.add((histPath + "hCentralityDistributionNGlobal").c_str(), "hCentralityDistributionNGlobal", {kTH1D, {{axisCentrality}}})});
histPointers.insert({histPath + "hCentralityDistributionMFT", histos.add((histPath + "hCentralityDistributionMFT").c_str(), "hCentralityDistributionMFT", {kTH1D, {{axisCentrality}}})});
}

histPointers.insert({histPath + "hFT0AvsPVz_Collisions", histos.add((histPath + "hFT0AvsPVz_Collisions").c_str(), "hFT0AvsPVz_Collisions", {kTProfile, {{axisPVz}}})});
histPointers.insert({histPath + "hFT0CvsPVz_Collisions", histos.add((histPath + "hFT0CvsPVz_Collisions").c_str(), "hFT0CvsPVz_Collisions", {kTProfile, {{axisPVz}}})});
histPointers.insert({histPath + "hFDDAvsPVz_Collisions", histos.add((histPath + "hFDDAvsPVz_Collisions").c_str(), "hFDDAvsPVz_Collisions", {kTProfile, {{axisPVz}}})});
Expand All @@ -245,8 +295,9 @@
histos.fill(HIST("hCollisionSelection"), 0); // all collisions
getHist(TH1, histPath + "hCollisionSelection")->Fill(0);

if (applySel8 && !collision.multSel8())
if (applySel8 && !collision.multSel8()) {
return;
}
histos.fill(HIST("hCollisionSelection"), 1);
getHist(TH1, histPath + "hCollisionSelection")->Fill(1);

Expand Down Expand Up @@ -331,8 +382,9 @@

// _______________________________________________________

if (applyVtxZ && TMath::Abs(collision.multPVz()) > 10)
if (applyVtxZ && TMath::Abs(collision.multPVz()) > vertexZcut.value) {
return;
}
histos.fill(HIST("hCollisionSelection"), 2);
getHist(TH1, histPath + "hCollisionSelection")->Fill(2);

Expand Down Expand Up @@ -418,6 +470,35 @@
getHist(TH1, histPath + "hNGlobalTracks_Unequalized")->Fill(collision.multNTracksGlobal());
getHist(TH1, histPath + "hNMFTTracks_Unequalized")->Fill(collision.mftNtracks());
}

if (doCentralityQA.value) {
// generate centralities on the spot in case the centrality histograms are in memory
if (hCentralityFV0A) {
getHist(TH1, histPath + "hCentralityDistributionFV0A")->Fill(hCentralityFV0A->GetBinContent(hCentralityFV0A->FindBin(multFV0A)));
}
if (hCentralityFT0A) {
getHist(TH1, histPath + "hCentralityDistributionFT0A")->Fill(hCentralityFT0A->GetBinContent(hCentralityFT0A->FindBin(multFT0A)));
}
if (hCentralityFT0C) {
getHist(TH1, histPath + "hCentralityDistributionFT0C")->Fill(hCentralityFT0C->GetBinContent(hCentralityFT0C->FindBin(multFT0C)));
}
if (hCentralityFT0M) {
getHist(TH1, histPath + "hCentralityDistributionFT0M")->Fill(hCentralityFT0M->GetBinContent(hCentralityFT0M->FindBin(multFT0A + multFT0C)));
}
if (hCentralityFDDM) {
getHist(TH1, histPath + "hCentralityDistributionFDDM")->Fill(hCentralityFDDM->GetBinContent(hCentralityFDDM->FindBin(multFDDA + multFDDC)));
}
if (hCentralityNTPV) {
// note: not vertex-Z-equalized to match what is done in central framework for this estimator
getHist(TH1, histPath + "hCentralityDistributionNTPV")->Fill(hCentralityNTPV->GetBinContent(hCentralityNTPV->FindBin(collision.multNTracksPV())));
}
if (hCentralityNGlo) {
getHist(TH1, histPath + "hCentralityDistributionNGlobal")->Fill(hCentralityNGlo->GetBinContent(hCentralityNGlo->FindBin(multNTracksGlobal)));
}
if (hCentralityMFT) {
getHist(TH1, histPath + "hCentralityDistributionMFT")->Fill(hCentralityMFT->GetBinContent(hCentralityMFT->FindBin(mftNtracks)));
}
}
}

void process(soa::Join<aod::MultsRun3, aod::MFTMults, aod::MultsExtra, aod::MultsGlobal, aod::MultSelections>::iterator const& collision)
Expand Down
Loading