Skip to content

[PWGHF] [xic0omegac0] Update codes to fix PID assignment in KFParticle#16381

Merged
fcatalan92 merged 13 commits into
AliceO2Group:masterfrom
jinhyunni:kfupdate
May 27, 2026
Merged

[PWGHF] [xic0omegac0] Update codes to fix PID assignment in KFParticle#16381
fcatalan92 merged 13 commits into
AliceO2Group:masterfrom
jinhyunni:kfupdate

Conversation

@jinhyunni
Copy link
Copy Markdown
Contributor

@jinhyunni jinhyunni commented May 26, 2026

This PR aims to fix PID assignment when using getTrackParCovFromKFP() method in candidateCreatorXic0Omegac0Qa.cxx code.

@fcatalan92, @mtorresc15

@github-actions github-actions Bot added the pwghf PWG-HF label May 26, 2026
@github-actions github-actions Bot changed the title [xic0omegac0] Update codes to fix PID assignment in KFParticle [PWGHF] [xic0omegac0] Update codes to fix PID assignment in KFParticle May 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@fcatalan92
Copy link
Copy Markdown
Collaborator

@jinhyunni Thanks for spotting and fixing this issue! The PR is fine for me, however I think you can solve the same issue in a cleaner way if you define a helper function that converts the PDG code to the correct o2::track::PID one, as Fernanda did in #16352 .

@jinhyunni
Copy link
Copy Markdown
Contributor Author

Hi @fcatalan92, thank you for reviewing this PR and for sharing your thoughts on this point.

I agree that introducing a helper function would make the implementation cleaner. My initial intention was to keep these assignments together with the other decay-channel-dependent variables in the init function, so that all hypotheses for each reconstruction channel are defined in one place.

That said, if you think the helper-function approach would be better for maintainability or consistency with the existing code style, I would be happy to update the implementation accordingly.

@fcatalan92
Copy link
Copy Markdown
Collaborator

That said, if you think the helper-function approach would be better for maintainability or consistency with the existing code style, I would be happy to update the implementation accordingly.

Hi @jinhyunni, yes, if you have time, it would be great if you could update the PR using the helper-function approach. Thanks!

Please consider the following formatting changes to AliceO2Group#16381
@jinhyunni
Copy link
Copy Markdown
Contributor Author

Hi @fcatalan92, thank you for your guidance on how to better organize the code.
I have revised this PR according to your recommendation.
Could you please take another look, and if there are no further changes needed, would you be able to merge this PR?

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c8b1aa9 at 2026-05-27 07:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:516:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c8b1aa9 at 2026-05-27 07:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:516:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 4fc0b25 at 2026-05-27 07:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:516:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@jinhyunni
Copy link
Copy Markdown
Contributor Author

Error while checking build/O2Physics/staging for 4fc0b25 at 2026-05-27 07:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0Qa.cxx:516:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

This issue was caused by missing return value at default case, and it was fixed with the latest commit(ab89135).

@fcatalan92 fcatalan92 merged commit a1c3d64 into AliceO2Group:master May 27, 2026
13 checks passed
@jinhyunni jinhyunni deleted the kfupdate branch May 27, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants