Skip to content

[PWGCF] multiharmonicCorrelations: Add nested loops for cross check#16889

Open
pengchon wants to merge 3 commits into
AliceO2Group:masterfrom
pengchon:master
Open

[PWGCF] multiharmonicCorrelations: Add nested loops for cross check#16889
pengchon wants to merge 3 commits into
AliceO2Group:masterfrom
pengchon:master

Conversation

@pengchon

@pengchon pengchon commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 50 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title add nested loops [PWGCF] add nested loops Jul 1, 2026
@vkucera

vkucera commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@pengchon You PR title is too vague. Please read the contribution guidelines and update it accordingly.

@pengchon pengchon changed the title [PWGCF] add nested loops [PWGCF] add nested loops for cross check Jul 1, 2026

@abilandz abilandz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all problems with MegaLinter, some of which were not obivous.

Please add more verbosity and decription to the title of your next PRs, per vkucera's remark.

@abilandz abilandz enabled auto-merge (squash) July 1, 2026 15:21
@vkucera vkucera changed the title [PWGCF] add nested loops for cross check [PWGCF] multiharmonicCorrelations: add nested loops for cross check Jul 1, 2026
@vkucera vkucera changed the title [PWGCF] multiharmonicCorrelations: add nested loops for cross check [PWGCF] multiharmonicCorrelations: Add nested loops for cross check Jul 1, 2026
@vkucera vkucera disabled auto-merge July 1, 2026 15:30
@vkucera vkucera enabled auto-merge (squash) July 1, 2026 15:31
@vkucera

vkucera commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@abilandz Please note that the PR title can be modified at any moment until the merge confirmation, so please do not merge a PR if you are aware that the title should be changed.

@abilandz

abilandz commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@abilandz Please note that the PR title can be modified at any moment until the merge confirmation, so please do not merge a PR if you are aware that the title should be changed.

That is fine, but since the student has invested quite some time and effort to fix MegaLinter problems, I do not want to hold him back with such trivial things, as he has much more urgent checks to perform with the new code. On a side note, the title is perfectly fine and meaningful for people which work with correlations techniques.

We have acknowledged your remark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants