Skip to content

[PWGEM,PWGLF] add ZDC info#16894

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master
Jul 1, 2026
Merged

[PWGEM,PWGLF] add ZDC info#16894
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

@dsekihat dsekihat commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM,PWGLF] add ZDC info

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 222 errors, ⚠️ 203 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) July 1, 2026 16:01

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

alibuild commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3b6cbac at 2026-07-01 19:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ grep -E '^/O2Physics/.+: error: ' /sw/BUILD/631cf143ea8afe30c8006251638817f368ba2110/O2Physics-code-check/error-log.txt
++ sed -e s,/O2Physics/,,g
++ sort -V
++ uniq
++ grep -E '^/O2Physics/.+: warning: ' /sw/BUILD/631cf143ea8afe30c8006251638817f368ba2110/O2Physics-code-check/error-log.txt
++ sed -e s,/O2Physics/,,g
++ sort -V
++ uniq
+++ wc -l
++ N_ERROR=52
+++ wc -l
++ N_WARNING=4
++ echo 'Found 52 errors and 4 warnings.'
Found 52 errors and 4 warnings.
++ [[ 52 -gt 0 ]]
++ cat /sw/BUILD/631cf143ea8afe30c8006251638817f368ba2110/O2Physics-code-check/errors.txt
PWGEM/Dilepton/DataModel/EvSelFlags.h:15:1: error: unknown type name 'namespace' [clang-diagnostic-error]
PWGEM/Dilepton/DataModel/EvSelFlags.h:15:13: error: expected ';' after top level declarator [clang-diagnostic-error]
PWGEM/Dilepton/DataModel/dileptonTables.h:12:1: error: included header EvSelFlags.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:14:10: error: 'Common/CCDB/EventSelectionParams.h' file not found [clang-diagnostic-error]
PWGEM/Dilepton/DataModel/dileptonTables.h:38:11: error: variable 'o2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:17:10: error: 'PWGEM/Dilepton/DataModel/dileptonTables.h' file not found [clang-diagnostic-error]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:34:1: error: included header iostream is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:35:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:37:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:44:8: error: constructor does not initialize these fields: mcevents, mceventlabels, emmcparticles, emmcgenvms, emprimaryelectronmclabels, emprimarymuonmclabels, emmftmclabels, engine, cache [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:104:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:105:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:128:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:129:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/associateMCinfoDilepton.cxx:153:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:16:10: error: 'PWGEM/Dilepton/DataModel/dileptonTables.h' file not found [clang-diagnostic-error]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:38:1: error: included header string is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:39:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:65:8: error: constructor does not initialize these fields: embc, event, eventXY, eventcov, event_mult, event_cent, event_qvec2, event_qvec3, event_zdc, event_norm_info [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:107:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:134:9: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:142:57: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:181:55: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx:308:8: error: constructor does not initialize these fields: prmeleventid, prmmueventid, prmtrackeventid [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:15:10: error: 'PWGEM/Dilepton/DataModel/dileptonTables.h' file not found [clang-diagnostic-error]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:48:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:49:1: error: included header string is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:50:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:52:1: error: included header unordered_map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:53:1: error: included header utility is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@dsekihat dsekihat merged commit 1f1c341 into AliceO2Group:master Jul 1, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants