Skip to content

[PWGLF] NucleiTask - Fix rapidity cuts with shifted pT#16898

Open
giovannimalfattore wants to merge 1 commit into
AliceO2Group:masterfrom
giovannimalfattore:fix-shifted-pt-rapidity-cut-clean
Open

[PWGLF] NucleiTask - Fix rapidity cuts with shifted pT#16898
giovannimalfattore wants to merge 1 commit into
AliceO2Group:masterfrom
giovannimalfattore:fix-shifted-pt-rapidity-cut-clean

Conversation

@giovannimalfattore

@giovannimalfattore giovannimalfattore commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • Fix rapidity cuts with shifted pT for deuteron and helium
  • Introduce templates for rapidity and momentum estimation from pT
  • Clean up code

@github-actions github-actions Bot added the pwglf label Jul 1, 2026
@github-actions github-actions Bot changed the title NucleiTask - Fix rapidity cuts with shifted pT [PWGLF] NucleiTask - Fix rapidity cuts with shifted pT Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 2 disabled

@alibuild

alibuild commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f411983 at 2026-07-02 00:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 25 errors and 426 warnings.'
Found 25 errors and 426 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/9c452fef54e6484377e7e45b333c78de75ee4c56/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:70:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:251:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:270:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:274:26: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:355:28: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:355:60: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:355:91: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:355:125: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:355:153: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2768:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:3486:26: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:3487:26: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4289:13: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4315:13: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4348:15: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4500:15: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4649:9: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4674:9: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4732:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4752:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:4866:13: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:5036:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:6489:12: error: implicit conversion 'size_type' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:6489:22: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:6799:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
++ [[ 426 -gt 0 ]]
++ cat /sw/BUILD/9c452fef54e6484377e7e45b333c78de75ee4c56/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:530:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:532:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:548:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:550:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:565:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:567:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:586:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:1809:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:1939:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2224:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2226:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2335:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2342:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2364:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/lfNucleiBATask.cxx:2388:26: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giovannimalfattore @alibuild