[PWGCF] Run 3 Magnetic Field Path and configurable added - #17782
Conversation
|
O2 linter results: ❌ 3 errors, |
[PWGCF] Please consider the following formatting changes to AliceO2Group#17782
|
@nmallick19 Please specify the location of the changes in the PR title. |
|
@vkucera Hi! The code is in [PWGCF], this is added already. Sorry, I did not follow which location do I have to add here? |
Please read the contribution guidelines. |
|
Sorry, I am confused here. The locations of the changes made to the file cannot be put in the title itself, there are too many changes, and therefore, we have the "Files changed" tab. I am checking some of the older commits, none of them seem to add any location of changes in the title. I cannot understand what changed recently, I did not commit to this repo for the first time. Can you please direct me to one such "ideal" PR to take as an example? I am curious at this point. Thank you. |
@nmallick19 There are examples in the contribution guidelines. Did you actually read them? |
|
I don't see either what makes it incomplete. The location was added, and the title describes the changes. I assume you refer to the guidelines here. Everything checks out. |
Magnetic field is needed for the two track cut to work
Magnetic field is cached per run, so repeated calls are now avoided per timestamp
Assuming that magnetic field does not change for a given run number