Skip to content

[PWGCF] Run 3 Magnetic Field Path and configurable added - #17782

Merged
jaelpark merged 3 commits into
AliceO2Group:masterfrom
nmallick19:master
Sep 5, 2026
Merged

[PWGCF] Run 3 Magnetic Field Path and configurable added#17782
jaelpark merged 3 commits into
AliceO2Group:masterfrom
nmallick19:master

Conversation

@nmallick19

Copy link
Copy Markdown
Contributor

Magnetic field is needed for the two track cut to work
Magnetic field is cached per run, so repeated calls are now avoided per timestamp
Assuming that magnetic field does not change for a given run number

@github-actions github-actions Bot added the pwgcf label Sep 5, 2026
@github-actions github-actions Bot changed the title Run 3 Magnetic Field Path and configurable added [PWGCF] Run 3 Magnetic Field Path and configurable added Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 3 errors, ⚠️ 6 warnings, 🔕 0 disabled

[PWGCF] Please consider the following formatting changes to AliceO2Group#17782
@vkucera

vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

@nmallick19 Please specify the location of the changes in the PR title.

@nmallick19

Copy link
Copy Markdown
Contributor Author

@vkucera Hi! The code is in [PWGCF], this is added already. Sorry, I did not follow which location do I have to add here?

@vkucera

vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

@vkucera Hi! The code is in [PWGCF], this is added already. Sorry, I did not follow which location do I have to add here?

Please read the contribution guidelines.

@nmallick19

Copy link
Copy Markdown
Contributor Author

Sorry, I am confused here. The locations of the changes made to the file cannot be put in the title itself, there are too many changes, and therefore, we have the "Files changed" tab. I am checking some of the older commits, none of them seem to add any location of changes in the title. I cannot understand what changed recently, I did not commit to this repo for the first time. Can you please direct me to one such "ideal" PR to take as an example? I am curious at this point. Thank you.

@jaelpark
jaelpark enabled auto-merge (squash) September 5, 2026 18:08
@jaelpark
jaelpark merged commit 97775fd into AliceO2Group:master Sep 5, 2026
12 of 14 checks passed
@vkucera

vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Sorry, I am confused here. The locations of the changes made to the file cannot be put in the title itself, there are too many changes, and therefore, we have the "Files changed" tab. I am checking some of the older commits, none of them seem to add any location of changes in the title. I cannot understand what changed recently, I did not commit to this repo for the first time. Can you please direct me to one such "ideal" PR to take as an example? I am curious at this point. Thank you.

@nmallick19 There are examples in the contribution guidelines. Did you actually read them?
@jaelpark Why did you merge the PR with the incomplete title?

@jaelpark

jaelpark commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

I don't see either what makes it incomplete. The location was added, and the title describes the changes. I assume you refer to the guidelines here. Everything checks out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants