[PWGHF] Adding D0/Lc analysis task - #17808
laszlogyulai wants to merge 26 commits into
Conversation
Please consider the following formatting changes to AliceO2Group#17807
|
O2 linter results: ❌ 0 errors, |
|
Dear codeowners, Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908) |
The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example? |
|
Error while checking build/O2Physics/staging for 6629a3a at 2026-09-21 08:09: Full log here. |
Please consider the following formatting changes to AliceO2Group#17808
|
Hi @zhangbiao-phy , could you check if the corrections are fine? |
|
Error while checking build/O2Physics/staging for c8d2457 at 2026-09-21 14:55: Full log here. |
|
Error while checking build/O2Physics/code-check for c8d2457 at 2026-09-21 14:55: Full log here. |
|
@laszlogyulai Please first compile and test your changes locally before updating the PR. |
Sure thing. The current (and previous) versions of the code compile and run smoothly on my local machine. Therefore, I am trying to solve the errors by looking at the output logs here. |
That's not the right approach. Your branch is obsolete. You should instead update it and re-test everything with the latest O2Physics. |
|
Error while checking build/O2Physics/o2 for c8d2457 at 2026-09-21 17:33: Full log here. |
|
@zhangbiao-phy @vkucera I have updated my local installation of O2Physics, and now the code is compiling and running on the latest version as well. In the end, it was missing the recent addition of the PVMults table to the HF codes. Thank you for your guidance in figuring everything out. |
|
Error while checking build/O2Physics/code-check for fa93653 at 2026-09-24 04:46: Full log here. |
|
@laszlogyulai Please fix the errors reported by the code-check. You can reproduce (and fix) the errors by following the documentation instructions. See https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check |
|
@zhangbiao-phy Please do not merge PRs before the tests finish. |
Adding a new analysis task for calculating the D0/Lambda_c yield ratio as a function of flattenicity